Details
Details
- Reviewers
ldionne Mordante - Group Reviewers
Restricted Project Restricted Project - Commits
- rG0a4aa8a122aa: [libc++] Granularize <type_traits> includes
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM w/ green CI.
Pinging vendors just for heads up, since this one might break a few users. type_traits is very common and some folks may have started compiling with -std=c++2b already.
Comment Actions
Is it only me that see problems like
******************** TEST 'llvm-libc++-shared.cfg.in :: libcxx/transitive_includes.sh.cpp' FAILED ********************
with this patch?
I get
$ ":" "RUN: at line 557" note: command had no output on stdout or stderr $ "diff" "-w" "/repo/uabelho/dev-main/libcxx/test/libcxx/transitive_includes/cxx2b.csv" "/repo/uabelho/dev-main/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/Output/transitive_includes.sh.cpp.dir/t.tmp/transitive_includes.csv" # command output: *** /repo/uabelho/dev-main/libcxx/test/libcxx/transitive_includes/cxx2b.csv --- /repo/uabelho/dev-main/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/Output/transitive_includes.sh.cpp.dir/t.tmp/transitive_includes.csv *************** *** 245,251 **** formatstring formatstring_view formattuple - formattype_traits formatvector formatversion forward_listcompare --- 245,250 ---- error: command failed with exit status: 1
Comment Actions
I submitted https://github.com/llvm/llvm-project/commit/8227349f7e4f1a6ceb4cceb464c8f4420ff1dd0a to address errors we started seeing in <optional> after this. Leaving a comment here so the author can take a look and check if this is reasonable.