This only covers the common load/store case. There will be further patches required for masked load/store and some of the fast-path optimization cases.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp | ||
|---|---|---|
| 1425 | Should we call TypeStoreSize.getFixedValue() while we're here instead of using implicit conversion to unsigned? | |
| llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp | ||
|---|---|---|
| 1425 | Honestly, it should probably be a switch inside a condition. Mind if I do that as a separate post commit? I'd like to keep the change isolated here. | |
| llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp | ||
|---|---|---|
| 1425 | Sure. | |
Comment Actions
Changes are look reasonable and good to me, but I am also new for ASan too, I guess we need few more eye to review.
Should we call TypeStoreSize.getFixedValue() while we're here instead of using implicit conversion to unsigned?