This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add classes to define SchedWrite list
ClosedPublic

Authored by pcwang-thead on Mar 1 2023, 12:57 AM.

Details

Summary

SchedWrites are relevant to LMUL for most instructions, so we have
to enumerate all defined SchedWrites when defining ReadAdcance.
This patch adds some classes to simplify these definitions.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 12:57 AM
pcwang-thead requested review of this revision.Mar 1 2023, 12:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 12:57 AM
michaelmaitland added inline comments.Mar 1 2023, 9:38 AM
llvm/lib/Target/RISCV/RISCVScheduleV.td
48

contained -> containing

50

I'm not sure that this class simplifies definitions of writes since this class does not define any SchedWrites. Perhaps a better description would be something like This class can be used to construct a list of existing definitions of writes corresponding to each (name, LMUL) pair, that are needed by the ReadAdvance.

Update comment.

pcwang-thead marked 2 inline comments as done.

Remove changes by accident.

This revision is now accepted and ready to land.Mar 2 2023, 8:49 AM
This revision was automatically updated to reflect the committed changes.