This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Add f16 and v2f16 ldg builtins
ClosedPublic

Authored by jchlanda on Feb 28 2023, 6:00 AM.

Details

Summary

Adds f16 and v2f16 ldg builtins and relevant tests.

Diff Detail

Event Timeline

jchlanda created this revision.Feb 28 2023, 6:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 6:00 AM
jchlanda requested review of this revision.Feb 28 2023, 6:00 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 28 2023, 6:00 AM
tra accepted this revision.Feb 28 2023, 10:36 AM
tra added inline comments.
llvm/test/CodeGen/NVPTX/ldu-ldg.ll
5–7

Do we want to add missing ldu variants, too?

38–46

Nit: I'd give test functions more descriptive names. E.g. test_ldg_u16.

This revision is now accepted and ready to land.Feb 28 2023, 10:36 AM
jchlanda updated this revision to Diff 501392.Mar 1 2023, 12:07 AM

Add more verbose test names.

jchlanda added inline comments.Mar 1 2023, 12:09 AM
llvm/test/CodeGen/NVPTX/ldu-ldg.ll
5–7

Looks like none of the ldu builtins have been exposed yet. I'll do it in a follow up patch.

38–46

Sure, done now.

This revision was automatically updated to reflect the committed changes.