This is an archive of the discontinued LLVM Phabricator instance.

Differential D144835

[CMake] Allow custom `CMAKE_BUILD_TYPE`s
ClosedPublic

Authored by fsb4000 on Feb 26 2023, 4:11 PM.

Details

Reviewers
bogner
whisperity
Mordante
Commits
rGc75dbeda15c1: [CMake] Allow custom `CMAKE_BUILD_TYPE`s
Summary

Fixes https://github.com/llvm/llvm-project/issues/60975

Diff Detail

Unit TestsFailed

TimeTest
60,270 msx64 debian > libFuzzer.libFuzzer::cross_over_uniform_dist.test
60,080 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,060 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
60,070 msx64 debian > libFuzzer.libFuzzer::out-of-process-fuzz.test
60,060 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

fsb4000 created this revision.Feb 26 2023, 4:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2023, 4:11 PM
fsb4000 requested review of this revision.Feb 26 2023, 4:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2023, 4:11 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fsb4000 added reviewers: bogner, whisperity.Feb 26 2023, 4:13 PM
Herald added a subscriber: rnkovacs. · View Herald TranscriptFeb 26 2023, 4:13 PM
Harbormaster completed remote builds in B216116: Diff 500634.Feb 26 2023, 5:11 PM
fsb4000 added a reviewer: Mordante.Mar 4 2023, 4:57 AM
bogner accepted this revision.Mar 6 2023, 10:23 AM
This revision is now accepted and ready to land.Mar 6 2023, 10:23 AM
This revision was landed with ongoing or failed builds.Mar 6 2023, 4:49 PM
Closed by commit rGc75dbeda15c1: [CMake] Allow custom `CMAKE_BUILD_TYPE`s (authored by fsb4000). · Explain Why
This revision was automatically updated to reflect the committed changes.
fsb4000 added a commit: rGc75dbeda15c1: [CMake] Allow custom `CMAKE_BUILD_TYPE`s.

Revision Contents

PathSize
llvm/
2 lines

Diff 500634

llvm/CMakeLists.txt

Show First 20 Lines • Show All 382 Lines • ▼ Show 20 Lines
This process created the file `CMakeCache.txt' and the directory `CMakeFiles'. This process created the file `CMakeCache.txt' and the directory `CMakeFiles'.
Please delete them.") Please delete them.")
endif() endif()
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE) string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
if (CMAKE_BUILD_TYPE AND if (CMAKE_BUILD_TYPE AND
NOT uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELEASE|RELWITHDEBINFO|MINSIZEREL)$") NOT uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELEASE|RELWITHDEBINFO|MINSIZEREL)$")
message(FATAL_ERROR "Invalid value for CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}") message(WARNING "Unknown value for CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
endif() endif()
# LLVM_INSTALL_PACKAGE_DIR needs to be declared prior to adding the tools # LLVM_INSTALL_PACKAGE_DIR needs to be declared prior to adding the tools
# subdirectory in order to have the value available for llvm-config. # subdirectory in order to have the value available for llvm-config.
include(GNUInstallPackageDir) include(GNUInstallPackageDir)
set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING
"Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')") "Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')")
▲ Show 20 Lines • Show All 952 Lines • Show Last 20 Lines