Page MenuHomePhabricator

fsb4000 (Igor Zhukov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2022, 12:04 AM (58 w, 5 d)

Recent Activity

Sat, Mar 25

fsb4000 accepted D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode.

Sorry, I didn't have time on the weekdays. But I have time today.

Sat, Mar 25, 5:28 AM · Restricted Project, Restricted Project

Sun, Mar 19

fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.

@philnik , Okay, I'll deal with that tomorrow.

Sun, Mar 19, 9:50 AM · Restricted Project, Restricted Project
fsb4000 retitled D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant` from [libc++]Don't warn when using operator<=> with 0 to [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 9:27 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 9:23 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 7:55 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 7:28 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 7:00 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 6:26 AM · Restricted Project, Restricted Project
fsb4000 added inline comments to D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sun, Mar 19, 4:32 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.

removed unneeded _LIBCPP_HIDE_FROM_ABI

Sun, Mar 19, 4:32 AM · Restricted Project, Restricted Project

Sat, Mar 18

fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sat, Mar 18, 9:32 PM · Restricted Project, Restricted Project
fsb4000 updated the summary of D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sat, Mar 18, 9:16 PM · Restricted Project, Restricted Project
fsb4000 updated the summary of D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sat, Mar 18, 9:06 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sat, Mar 18, 8:52 PM · Restricted Project, Restricted Project
fsb4000 updated the summary of D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sat, Mar 18, 8:38 PM · Restricted Project, Restricted Project
fsb4000 requested review of D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Sat, Mar 18, 7:19 PM · Restricted Project, Restricted Project

Sun, Mar 12

fsb4000 added a comment to D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

The tests passed and I added more reviewers to this patch.

Sun, Mar 12, 12:29 AM · Restricted Project, Restricted Project
fsb4000 added reviewers for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`: philnik, ldionne, huixie90.
Sun, Mar 12, 12:28 AM · Restricted Project, Restricted Project

Sat, Mar 11

fsb4000 added a comment to D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

I think I fixed the CI when I revert the commit: https://github.com/llvm/llvm-project/commit/24416d22bb284cf24335ee7aa63131e5de56a1bb

Sat, Mar 11, 11:03 PM · Restricted Project, Restricted Project
fsb4000 added a reverting change for rGb00aaab730ae: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag: rG24416d22bb28: Revert "[CMake] Unify llvm_check_linker_flag and….
Sat, Mar 11, 10:59 PM · Restricted Project
fsb4000 committed rG24416d22bb28: Revert "[CMake] Unify llvm_check_linker_flag and… (authored by fsb4000).
Revert "[CMake] Unify llvm_check_linker_flag and…
Sat, Mar 11, 10:59 PM · Restricted Project
fsb4000 added a reverting change for D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag: rG24416d22bb28: Revert "[CMake] Unify llvm_check_linker_flag and….
Sat, Mar 11, 10:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
fsb4000 closed D145858: Revert "[CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag".
Sat, Mar 11, 10:59 PM · Restricted Project, Restricted Project, Restricted Project
fsb4000 added a comment to D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.

I'm going to revert this commit.

Sat, Mar 11, 10:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
fsb4000 requested review of D145858: Revert "[CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag".
Sat, Mar 11, 9:35 PM · Restricted Project, Restricted Project, Restricted Project
fsb4000 added a comment to D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Ok, I think current CI failures are not your fault.

Sat, Mar 11, 7:06 PM · Restricted Project, Restricted Project

Thu, Mar 9

fsb4000 committed rG882fba9ff275: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs (authored by fsb4000).
[libc++][ranges] Implement LWG-3865 Sorting a range of pairs
Thu, Mar 9, 6:04 PM · Restricted Project, Restricted Project
fsb4000 closed D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.
Thu, Mar 9, 6:04 PM · Restricted Project, Restricted Project
fsb4000 added inline comments to D136522: [libcxx] patch for implementing ranges::find_last.
Thu, Mar 9, 1:21 AM · Restricted Project, Restricted Project, Restricted Project
fsb4000 added inline comments to D136522: [libcxx] patch for implementing ranges::find_last.
Thu, Mar 9, 1:19 AM · Restricted Project, Restricted Project, Restricted Project
fsb4000 added inline comments to D136522: [libcxx] patch for implementing ranges::find_last.
Thu, Mar 9, 1:18 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

fsb4000 committed rG9619794c253a: [libc++][test] Fix transitive_includes (authored by fsb4000).
[libc++][test] Fix transitive_includes
Wed, Mar 8, 10:29 PM · Restricted Project, Restricted Project
fsb4000 closed D145651: [libc++] Fix transitive_includes.
Wed, Mar 8, 10:29 PM · Restricted Project, Restricted Project
fsb4000 requested review of D145651: [libc++] Fix transitive_includes.
Wed, Mar 8, 10:00 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.

add static_assert(!HasSpaceship<std::pair<int, int>, std::pair<std::string, int>>);

Wed, Mar 8, 9:09 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.
Wed, Mar 8, 2:34 AM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.
Wed, Mar 8, 2:14 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.
Wed, Mar 8, 2:13 AM · Restricted Project, Restricted Project

Tue, Mar 7

fsb4000 added a comment to D145376: [libc++] add declval failure assertion for instantiation.

I've created https://github.com/llvm/llvm-project/issues/61254

Tue, Mar 7, 6:17 PM · Restricted Project, Restricted Project
fsb4000 added a comment to D145376: [libc++] add declval failure assertion for instantiation.

What do you mean?

Tue, Mar 7, 5:21 PM · Restricted Project, Restricted Project

Mon, Mar 6

fsb4000 added inline comments to D145376: [libc++] add declval failure assertion for instantiation.
Mon, Mar 6, 10:12 PM · Restricted Project, Restricted Project
fsb4000 added inline comments to D145376: [libc++] add declval failure assertion for instantiation.
Mon, Mar 6, 9:38 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.
Mon, Mar 6, 9:22 PM · Restricted Project, Restricted Project
fsb4000 added inline comments to D145376: [libc++] add declval failure assertion for instantiation.
Mon, Mar 6, 9:05 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

fix a test

Mon, Mar 6, 5:08 PM · Restricted Project, Restricted Project
fsb4000 committed rGc75dbeda15c1: [CMake] Allow custom `CMAKE_BUILD_TYPE`s (authored by fsb4000).
[CMake] Allow custom `CMAKE_BUILD_TYPE`s
Mon, Mar 6, 4:49 PM · Restricted Project, Restricted Project
fsb4000 closed D144835: [CMake] Allow custom `CMAKE_BUILD_TYPE`s.
Mon, Mar 6, 4:49 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

add _LIBCPP_HIDE_FROM_ABI

Mon, Mar 6, 4:43 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.
Mon, Mar 6, 7:41 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

change a compile.fail test to a verify test

Mon, Mar 6, 7:24 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

add a test

Mon, Mar 6, 6:45 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

inline variables is a c++17 feature

Mon, Mar 6, 6:38 AM · Restricted Project, Restricted Project
fsb4000 requested review of D145376: [libc++] add declval failure assertion for instantiation.
Mon, Mar 6, 6:24 AM · Restricted Project, Restricted Project

Sat, Mar 4

fsb4000 added a reviewer for D144835: [CMake] Allow custom `CMAKE_BUILD_TYPE`s: Mordante.
Sat, Mar 4, 4:57 AM · Restricted Project, Restricted Project

Fri, Mar 3

fsb4000 added a comment to D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

I think you should add ranges new beetween these two lines: https://github.com/llvm/llvm-project/blob/fac4c476b97b9f2a9dace059f084696d856c033b/libcxx/test/libcxx/transitive_includes/cxx03.csv#L647-L648 and https://github.com/llvm/llvm-project/blob/main/libcxx/test/libcxx/transitive_includes/cxx11.csv#L648-L649

Fri, Mar 3, 11:09 PM · Restricted Project, Restricted Project

Mar 2 2023

fsb4000 abandoned D145127: [libc++][doc] Mark LWG-3720 as "Nothing to do".
Mar 2 2023, 3:07 PM · Restricted Project, Restricted Project
fsb4000 added inline comments to D145127: [libc++][doc] Mark LWG-3720 as "Nothing to do".
Mar 2 2023, 3:07 PM · Restricted Project, Restricted Project

Mar 1 2023

fsb4000 requested review of D145127: [libc++][doc] Mark LWG-3720 as "Nothing to do".
Mar 1 2023, 3:50 PM · Restricted Project, Restricted Project

Feb 28 2023

fsb4000 added inline comments to D140343: [libc++] Update supported system versions.
Feb 28 2023, 3:21 PM · Restricted Project, Restricted Project

Feb 27 2023

fsb4000 updated the diff for D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.

fix formatting conflicts in libcxx/include/utility

Feb 27 2023, 3:23 PM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.
Feb 27 2023, 2:55 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs.

I rebased and added tests to pair's spaceship operator.

Feb 27 2023, 2:54 PM · Restricted Project, Restricted Project
fsb4000 closed D144338: [libc++][ranges] Implement LWG-3860 range_common_reference_t is missing.
Feb 27 2023, 6:02 AM · Restricted Project, Restricted Project
fsb4000 added a comment to D144338: [libc++][ranges] Implement LWG-3860 range_common_reference_t is missing.

I landed https://github.com/llvm/llvm-project/commit/a8ead9194cfb18922408404c8cabfa83c276944f but I forgot to add

Feb 27 2023, 5:53 AM · Restricted Project, Restricted Project
fsb4000 committed rGa8ead9194cfb: [libc++][ranges] Implement LWG-3860 range_common_reference_t is missing (authored by fsb4000).
[libc++][ranges] Implement LWG-3860 range_common_reference_t is missing
Feb 27 2023, 5:50 AM · Restricted Project, Restricted Project

Feb 26 2023

fsb4000 added reviewers for D144835: [CMake] Allow custom `CMAKE_BUILD_TYPE`s: bogner, whisperity.
Feb 26 2023, 4:13 PM · Restricted Project, Restricted Project
fsb4000 requested review of D144835: [CMake] Allow custom `CMAKE_BUILD_TYPE`s.
Feb 26 2023, 4:11 PM · Restricted Project, Restricted Project
fsb4000 accepted D135248: [libc++] implement move_iterator<T*> should be a random access iterator .

Microsoft STL treats this paper as a DR and I agree with Casey Carter that the code breakage will be minimal because the move_iterators are still input iterators in C++20.

Feb 26 2023, 3:53 PM · Restricted Project, Restricted Project, Restricted Project
fsb4000 added inline comments to D135248: [libc++] implement move_iterator<T*> should be a random access iterator .
Feb 26 2023, 8:48 AM · Restricted Project, Restricted Project, Restricted Project
fsb4000 added inline comments to D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 26 2023, 6:29 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.

restore const char in test\libcxx\memory\trivial_abi\unique_ptr_destruction_order.pass.cpp

Feb 26 2023, 6:21 AM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 26 2023, 6:17 AM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 26 2023, 6:05 AM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 26 2023, 5:51 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 26 2023, 2:08 AM · Restricted Project, Restricted Project

Feb 25 2023

fsb4000 added inline comments to D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 9:28 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 9:28 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 7:33 PM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144338: [libc++][ranges] Implement LWG-3860 range_common_reference_t is missing.
Feb 25 2023, 6:36 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 6:33 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 6:16 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 8:06 AM · Restricted Project, Restricted Project
fsb4000 committed rG9d53c8684fe2: [libc++] Implement LWG-3204: `sub_match::swap` only swaps the base class (authored by fsb4000).
[libc++] Implement LWG-3204: `sub_match::swap` only swaps the base class
Feb 25 2023, 6:45 AM · Restricted Project, Restricted Project
fsb4000 closed D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class.
Feb 25 2023, 6:45 AM · Restricted Project, Restricted Project
fsb4000 added inline comments to D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class.
Feb 25 2023, 6:23 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 5:36 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 25 2023, 4:15 AM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.

fix more tests

Feb 25 2023, 3:54 AM · Restricted Project, Restricted Project

Feb 24 2023

fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 24 2023, 11:27 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.

fix tests

Feb 24 2023, 11:24 PM · Restricted Project, Restricted Project
fsb4000 updated the summary of D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 24 2023, 10:10 PM · Restricted Project, Restricted Project
fsb4000 requested review of D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.
Feb 24 2023, 10:00 PM · Restricted Project, Restricted Project
fsb4000 added a comment to D144694: [libc++][test] Silence MSVC deprecation warnings.

Thanks @philnik , I found the warning: -Wdeprecated-copy-with-user-provided-dtor: https://godbolt.org/z/rr186sGYK

Feb 24 2023, 7:57 PM · Restricted Project, Restricted Project
fsb4000 added a reviewer for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`: var-const.
Feb 24 2023, 7:17 PM · Restricted Project, Restricted Project
fsb4000 updated the diff for D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class.
Feb 24 2023, 6:58 PM · Restricted Project, Restricted Project
fsb4000 added a reviewer for D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class: philnik.
Feb 24 2023, 6:35 PM · Restricted Project, Restricted Project
fsb4000 added a reviewer for D144338: [libc++][ranges] Implement LWG-3860 range_common_reference_t is missing: philnik.
Feb 24 2023, 6:35 PM · Restricted Project, Restricted Project
fsb4000 added a reviewer for D144262: [libc++][ranges] Implement LWG-3865 Sorting a range of pairs: philnik.
Feb 24 2023, 6:35 PM · Restricted Project, Restricted Project
fsb4000 added reviewers for D144645: [libc++] Implement LWG-3655: The INVOKE operation and union types.: Mordante, philnik.
Feb 24 2023, 6:35 PM · Restricted Project, Restricted Project
fsb4000 added a reviewer for D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class: Mordante.
Feb 24 2023, 6:34 PM · Restricted Project, Restricted Project