User Details
- User Since
- Feb 14 2022, 12:04 AM (58 w, 5 d)
Sat, Mar 25
Sorry, I didn't have time on the weekdays. But I have time today.
Sun, Mar 19
@philnik , Okay, I'll deal with that tomorrow.
removed unneeded _LIBCPP_HIDE_FROM_ABI
Sat, Mar 18
Sun, Mar 12
The tests passed and I added more reviewers to this patch.
Sat, Mar 11
I think I fixed the CI when I revert the commit: https://github.com/llvm/llvm-project/commit/24416d22bb284cf24335ee7aa63131e5de56a1bb
I'm going to revert this commit.
Ok, I think current CI failures are not your fault.
Thu, Mar 9
Wed, Mar 8
add static_assert(!HasSpaceship<std::pair<int, int>, std::pair<std::string, int>>);
Tue, Mar 7
I've created https://github.com/llvm/llvm-project/issues/61254
What do you mean?
Mon, Mar 6
fix a test
add _LIBCPP_HIDE_FROM_ABI
change a compile.fail test to a verify test
add a test
inline variables is a c++17 feature
Sat, Mar 4
Fri, Mar 3
I think you should add ranges new beetween these two lines: https://github.com/llvm/llvm-project/blob/fac4c476b97b9f2a9dace059f084696d856c033b/libcxx/test/libcxx/transitive_includes/cxx03.csv#L647-L648 and https://github.com/llvm/llvm-project/blob/main/libcxx/test/libcxx/transitive_includes/cxx11.csv#L648-L649
Mar 2 2023
Mar 1 2023
Feb 28 2023
Feb 27 2023
fix formatting conflicts in libcxx/include/utility
I rebased and added tests to pair's spaceship operator.
I landed https://github.com/llvm/llvm-project/commit/a8ead9194cfb18922408404c8cabfa83c276944f but I forgot to add
Feb 26 2023
Microsoft STL treats this paper as a DR and I agree with Casey Carter that the code breakage will be minimal because the move_iterators are still input iterators in C++20.
restore const char in test\libcxx\memory\trivial_abi\unique_ptr_destruction_order.pass.cpp
Feb 25 2023
fix more tests
Feb 24 2023
fix tests
Thanks @philnik , I found the warning: -Wdeprecated-copy-with-user-provided-dtor: https://godbolt.org/z/rr186sGYK