[mlir] Add setters for Dynamic[Type|Attr]Definition

[math-fehr]

Summary

Add functions to set the verifier, printer, and parser of
dynamic attributes definitions, and dynamic type definitions.

This feature was already implemented for dynamic operations, but
is missing for attributes and types. This is necessary to define
attributes and types verifiers that refer to each others in a cyclic way.

[math-fehr]

Thanks! Could one of you land this for me? I do not have write access to the repository.

mlir/include/mlir/IR/ExtensibleDialect.h

public:
   /// Create a new attribute definition at runtime. The attribute is registered
   /// only after passing it to the dialect using registerDynamicAttr.
   static std::unique_ptr<DynamicAttrDefinition>
   get(StringRef name, ExtensibleDialect *dialect, VerifierFn &&verifier);
   static std::unique_ptr<DynamicAttrDefinition>
   get(StringRef name, ExtensibleDialect *dialect, VerifierFn &&verifier,
       ParserFn &&parser, PrinterFn &&printer);
 
+  /// Sets the verifier function for this attribute. It should emits an error
+  /// message and returns failure if a problem is detected, or returns success
+  /// if everything is ok.
+  void setVerifyFn(VerifierFn &&verify) { verifier = std::move(verify); }
+
+  /// Sets the static hook for parsing this attribute assembly.
+  void setParseFn(ParserFn &&parse) { parser = std::move(parse); }
+
+  /// Sets the static hook for printing this attribute assembly.
+  void setPrintFn(PrinterFn &&print) { printer = std::move(print); }
+
   /// Check that the attribute parameters are valid.
   LogicalResult verify(function_ref<InFlightDiagnostic()> emitError,
                        ArrayRef<Attribute> params) const {
     return verifier(emitError, params);
   }
 
   /// Return the MLIRContext in which the dynamic attributes are uniqued.
   MLIRContext &getContext() const { return *ctx; }
public:
   /// Create a new dynamic type definition. The type is registered only after
   /// passing it to the dialect using registerDynamicType.
   static std::unique_ptr<DynamicTypeDefinition>
   get(StringRef name, ExtensibleDialect *dialect, VerifierFn &&verifier);
   static std::unique_ptr<DynamicTypeDefinition>
   get(StringRef name, ExtensibleDialect *dialect, VerifierFn &&verifier,
       ParserFn &&parser, PrinterFn &&printer);
 
+  /// Sets the verifier function for this type. It should emits an error
+  /// message and returns failure if a problem is detected, or returns success
+  /// if everything is ok.
+  void setVerifyFn(VerifierFn &&verify) { verifier = std::move(verify); }
+
+  /// Sets the static hook for parsing this type assembly.
+  void setParseFn(ParserFn &&parse) { parser = std::move(parse); }
+
+  /// Sets the static hook for printing this type assembly.
+  void setPrintFn(PrinterFn &&print) { printer = std::move(print); }
+
   /// Check that the type parameters are valid.
   LogicalResult verify(function_ref<InFlightDiagnostic()> emitError,
                        ArrayRef<Attribute> params) const {
     return verifier(emitError, params);
   }
 
   /// Return the MLIRContext in which the dynamic types is uniqued.
   MLIRContext &getContext() const { return *ctx; }