Page MenuHomePhabricator

math-fehr (Fehr Mathieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2021, 10:21 AM (89 w, 1 d)

Recent Activity

Sat, Sep 24

math-fehr added a comment to D134593: [mlir] Allow accessing TypeID of attrs/types defs.

Also, I do not have commit access, so would it be possible to land it for me if this is accepted?

Sat, Sep 24, 10:40 AM · Restricted Project, Restricted Project
math-fehr requested review of D134593: [mlir] Allow accessing TypeID of attrs/types defs.
Sat, Sep 24, 10:39 AM · Restricted Project, Restricted Project

Mon, Sep 19

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

Yes, this is ready! I just updated it to the main.

Mon, Sep 19, 9:53 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Remove use of deprecated methods

Mon, Sep 19, 9:46 AM · Restricted Project, Restricted Project

Sep 3 2022

math-fehr added a comment to D133264: [mlir][NFC] Provide accessor for TableGen record.

Addressed comments

Sep 3 2022, 4:47 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D133264: [mlir][NFC] Provide accessor for TableGen record.

Use documentation comments

Sep 3 2022, 4:45 PM · Restricted Project, Restricted Project
math-fehr added a comment to D133264: [mlir][NFC] Provide accessor for TableGen record.

By the way, I do not have commit access, so would it be possible to land it for me if this is accepted?

Sep 3 2022, 4:42 PM · Restricted Project, Restricted Project
math-fehr requested review of D133264: [mlir][NFC] Provide accessor for TableGen record.
Sep 3 2022, 4:41 PM · Restricted Project, Restricted Project

Aug 14 2022

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

Sorry for the delay, I forgot a bit about this patch!
@rriddle, I just rebased it, could you land this for me, I do not have commit access?

Aug 14 2022, 9:20 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Rebased on main

Aug 14 2022, 9:18 AM · Restricted Project, Restricted Project

May 25 2022

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

I should have addressed the comments.
Could you land this for me?

May 25 2022, 8:13 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Address comments

May 25 2022, 7:47 AM · Restricted Project, Restricted Project

May 24 2022

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

This should now be ready for review.
I added documentation for the dynamic dialect definition, and addressed the comments.

May 24 2022, 11:19 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Remove unwanted line break

May 24 2022, 11:16 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Address comments

May 24 2022, 11:14 AM · Restricted Project, Restricted Project

May 11 2022

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

I added an insertDynamic in the DialectRegistry.

My dynamic.mlir test is currently failing (it seems because of a memory issue), and I'll debug this tomorrow.

May 11 2022, 7:11 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Fix bug in dynamic dialect registration

May 11 2022, 7:03 PM · Restricted Project, Restricted Project

May 10 2022

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

I added an insertDynamic in the DialectRegistry.

May 10 2022, 10:12 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Address comments, and add insertDynamic to DialectRegistry.

May 10 2022, 10:03 PM · Restricted Project, Restricted Project

May 9 2022

math-fehr added a comment to D125200: [mlir][doc] Move documentation of extensible dialects.

Thanks, could you land this for me?

May 9 2022, 11:35 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125200: [mlir][doc] Move documentation of extensible dialects.

Add missing newline at end of file

May 9 2022, 11:34 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Add missing newline at end of file

May 9 2022, 1:11 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D125201: [mlir] Add Dynamic Dialects.

Add parsing and printing of types/attributes

May 9 2022, 1:08 AM · Restricted Project, Restricted Project

May 8 2022

math-fehr added a comment to D125201: [mlir] Add Dynamic Dialects.

I would like to add tests for dynamic dialects, by creating a new dynamic dialect, and then populating it with dynamic operations, types, and attributes.
However, the way mlir-opt currently works is by creating a DialectRegistry, and then passing it to MlirOptMain.

May 8 2022, 8:19 PM · Restricted Project, Restricted Project
math-fehr added a reviewer for D125201: [mlir] Add Dynamic Dialects: mikeurbach.
May 8 2022, 8:10 PM · Restricted Project, Restricted Project
math-fehr requested review of D125201: [mlir] Add Dynamic Dialects.
May 8 2022, 8:09 PM · Restricted Project, Restricted Project
math-fehr requested review of D125200: [mlir][doc] Move documentation of extensible dialects.
May 8 2022, 7:57 PM · Restricted Project, Restricted Project

Apr 26 2022

math-fehr added a comment to D124353: [mlir] Allow setting operation legality with an OperationName.

Can you rebase and reupload? The patch failed to apply.

Apr 26 2022, 9:16 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D124353: [mlir] Allow setting operation legality with an OperationName.

Rebase to latest version

Apr 26 2022, 8:52 PM · Restricted Project, Restricted Project

Apr 25 2022

math-fehr added a comment to D124353: [mlir] Allow setting operation legality with an OperationName.

I addressed the comments.
If this is good for you, could you land it once D104554 is landed?

Apr 25 2022, 1:16 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D124353: [mlir] Allow setting operation legality with an OperationName.

Address comments

Apr 25 2022, 1:14 PM · Restricted Project, Restricted Project
math-fehr added a comment to D104554: [mlir] Add extensible dialects.

I just changed the names of the types, attributes, and ops in the test dialect, to address the comment of D124353.
The patch is otherwise ready if the CI passes.

Apr 25 2022, 9:17 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Rename dynamic attributes/types/ops in test dialect

Apr 25 2022, 9:14 AM · Restricted Project, Restricted Project

Apr 24 2022

math-fehr updated the summary of D124353: [mlir] Allow setting operation legality with an OperationName.
Apr 24 2022, 5:48 PM · Restricted Project, Restricted Project
math-fehr requested review of D124353: [mlir] Allow setting operation legality with an OperationName.
Apr 24 2022, 5:44 PM · Restricted Project, Restricted Project
math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Everything should be ready now! Could you land this for me?
I'll merge the dialect documentation in a following patch!

Apr 24 2022, 4:42 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Update to latest MLIR, and format files

Apr 24 2022, 3:57 PM · Restricted Project, Restricted Project

Apr 21 2022

math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Fix compilation on windows machines

Apr 21 2022, 5:19 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Update to latest version

Apr 21 2022, 1:29 PM · Restricted Project, Restricted Project
math-fehr reopened D104554: [mlir] Add extensible dialects.
Apr 21 2022, 1:28 PM · Restricted Project, Restricted Project

Mar 3 2022

math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Thanks for taking care of this!
I'll try to figure out why windows is failing, and fix this in the next couple of days!

Mar 3 2022, 11:49 AM · Restricted Project, Restricted Project

Mar 2 2022

math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Fix bug in inheritance, and remove unnecessary code

Mar 2 2022, 2:20 AM · Restricted Project, Restricted Project

Feb 28 2022

math-fehr added a comment to D104554: [mlir] Add extensible dialects.

I rebased it to the latest commit, though I'm still investigating why the windows build is failing.

Feb 28 2022, 7:41 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Apply clang-format

Feb 28 2022, 7:12 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Update to latest commit

Feb 28 2022, 7:01 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Rebase to main

Feb 28 2022, 2:40 PM · Restricted Project, Restricted Project
math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Thanks a lot for your reviews!
I'll try to see if I manage to add printing/parsing support in the generatedTypeParser, and I'll try to make a patch for that soon!

Feb 28 2022, 6:37 AM · Restricted Project, Restricted Project

Feb 14 2022

math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Sorry for not being active enough on this, I addressed all comments here.
I tried to add support for TableGen parser/printer generation, and added it in the generated parseType.
Though, I'm not really sure how to integrate it (or if I should integrate it) in generatedTypeParser, since the TableGen generation do not have access to the dialect if there is no TableGen type/attribute definition.

Feb 14 2022, 9:31 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Address comments

Feb 14 2022, 9:26 AM · Restricted Project, Restricted Project

Feb 8 2022

math-fehr added a comment to D104534: [mlir] Add classes to define new TypeIDs at runtime.

No problem!

Feb 8 2022, 7:57 PM · Restricted Project

Jan 24 2022

math-fehr added a comment to D104534: [mlir] Add classes to define new TypeIDs at runtime.

Sorry, I just applied the last changes, and this should be ready to be committed I believe!
@rriddle, could you commit it for me if this is good for you? I do not have commit rights.

Jan 24 2022, 3:37 PM · Restricted Project
math-fehr updated the diff for D104534: [mlir] Add classes to define new TypeIDs at runtime.

Address comments, and rename class to SelfOwningTypeID

Jan 24 2022, 3:34 PM · Restricted Project

Nov 27 2021

math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Add some inline responses.
I think that for now it would be better to stick with attributes as parameters to move forward, if that makes sense to you!

Nov 27 2021, 6:23 PM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Address comments, and update to HEAD

Nov 27 2021, 6:21 PM · Restricted Project, Restricted Project

Nov 25 2021

math-fehr added a comment to D104534: [mlir] Add classes to define new TypeIDs at runtime.

Was this class what you add in mind? I can also define another class that owns its TypeID by having a pointer to some place in memory if this can be useful.

Nov 25 2021, 7:06 PM · Restricted Project
math-fehr retitled D104534: [mlir] Add classes to define new TypeIDs at runtime from [mlir] Add TypeIDAllocator class to [mlir] Add classes to define new TypeIDs at runtime.
Nov 25 2021, 7:03 PM · Restricted Project
math-fehr updated the diff for D104534: [mlir] Add classes to define new TypeIDs at runtime.

Add NonMovableTypeIDOwner, and remove TypeIDAllocator from MLIRContext

Nov 25 2021, 6:59 PM · Restricted Project

Nov 9 2021

math-fehr added inline comments to D104554: [mlir] Add extensible dialects.
Nov 9 2021, 6:26 PM · Restricted Project, Restricted Project

Oct 25 2021

math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Hey @rriddle, a gentle ping on this.

Oct 25 2021, 10:53 AM · Restricted Project, Restricted Project
math-fehr added a comment to D104534: [mlir] Add classes to define new TypeIDs at runtime.

Hey @rriddle, a gentle ping on this ^

Oct 25 2021, 10:50 AM · Restricted Project

Oct 14 2021

math-fehr added a comment to D111719: [mlir][NFC] Provide accessor for TableGen record for constraints.

Thanks, would it be possible to land it for me?

Oct 14 2021, 12:53 PM · Restricted Project
math-fehr added a comment to D111739: [mlir] Add AnyAttrOf tablegen attribute constraint.

Thanks, would it be possible to land it for me?

Oct 14 2021, 12:52 PM · Restricted Project

Oct 13 2021

math-fehr requested review of D111739: [mlir] Add AnyAttrOf tablegen attribute constraint.
Oct 13 2021, 9:29 AM · Restricted Project
math-fehr added a reviewer for D111719: [mlir][NFC] Provide accessor for TableGen record for constraints: rriddle.
Oct 13 2021, 8:10 AM · Restricted Project
math-fehr requested review of D111719: [mlir][NFC] Provide accessor for TableGen record for constraints.
Oct 13 2021, 8:09 AM · Restricted Project

Oct 12 2021

math-fehr added a comment to D104554: [mlir] Add extensible dialects.

All comments should be addressed now, besides two where I answered in the comments.

Oct 12 2021, 4:04 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.
  • Add attributes support
  • Fix grammar and spelling in the documentation
  • Change the type and attribute interfaces to traits
Oct 12 2021, 4:00 AM · Restricted Project, Restricted Project

Sep 12 2021

math-fehr added a comment to D105202: [mlir] Allows to query traits from types and attributes.

Hi Alex!
Yes, would it be possible to land it for me?
Thanks!

Sep 12 2021, 7:01 AM · Restricted Project

Sep 11 2021

math-fehr added a comment to D105202: [mlir] Allows to query traits from types and attributes.

Hey @rriddle, gentle ping on this!

Sep 11 2021, 6:34 PM · Restricted Project
math-fehr added a comment to D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.

Hey! I do not have commit access, could someone commit this patch?

Sep 11 2021, 6:28 PM · Restricted Project
math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Sorry for the delay!

Sep 11 2021, 6:23 PM · Restricted Project, Restricted Project

Jul 14 2021

math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Add a file in docs/ documenting the patch

Jul 14 2021, 7:52 AM · Restricted Project, Restricted Project

Jul 13 2021

math-fehr added a comment to D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.

Oh yes, thanks for that!
I realized that there was also already a llvm::disjunction in ADT/STLForwardCompat.h, so I used it.

Jul 13 2021, 3:35 PM · Restricted Project
math-fehr updated the diff for D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.

Remove llvm::conjunctions, and use llvm::disjunction

Jul 13 2021, 3:32 PM · Restricted Project

Jul 12 2021

math-fehr updated the diff for D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.

Fix compilation on windows by introducing and using llvm::conjuctions

Jul 12 2021, 6:23 AM · Restricted Project

Jul 5 2021

math-fehr added a comment to D104534: [mlir] Add classes to define new TypeIDs at runtime.

@rriddle, a gentle ping on this.
What do you think would be the best course of action here?
As I said in a previous comment, I could either keep the TypeIDAllocator in the MLIRContext, or move it to the ExtensibleDialect and having the "dynamic" objects owning their TypeIDs.

Jul 5 2021, 9:29 AM · Restricted Project
math-fehr retitled D105202: [mlir] Allows to query traits from types and attributes from [mlir] Allows to query traits from types to [mlir] Allows to query traits from types and attributes.
Jul 5 2021, 6:55 AM · Restricted Project
math-fehr updated the diff for D105202: [mlir] Allows to query traits from types and attributes.

Address comments, and add support for traits in attributes

Jul 5 2021, 6:54 AM · Restricted Project

Jun 30 2021

math-fehr requested review of D105202: [mlir] Allows to query traits from types and attributes.
Jun 30 2021, 9:12 AM · Restricted Project

Jun 28 2021

math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Fix memory error by allocating the dialect name in the MLIRContext.

Jun 28 2021, 1:37 PM · Restricted Project, Restricted Project
math-fehr added inline comments to D104554: [mlir] Add extensible dialects.
Jun 28 2021, 1:10 PM · Restricted Project, Restricted Project
math-fehr added a comment to D104554: [mlir] Add extensible dialects.

Sorry for the delay!

Can you write up a doc (in the docs/ folder) detailing everything here? It would make it easier to understand the design, how it is intended to be used, etc.

Jun 28 2021, 1:00 PM · Restricted Project, Restricted Project

Jun 27 2021

math-fehr updated the diff for D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.

Fix formatting

Jun 27 2021, 5:13 AM · Restricted Project

Jun 26 2021

math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Return nullptr instead of a FailureOr in lookupTypeDefinition

Jun 26 2021, 8:27 AM · Restricted Project, Restricted Project

Jun 24 2021

math-fehr updated the summary of D104554: [mlir] Add extensible dialects.
Jun 24 2021, 11:22 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Fix include guard name and use const_cast instead of an API change

Jun 24 2021, 11:22 AM · Restricted Project, Restricted Project
math-fehr abandoned D104862: [mlir] NFC: make Dialect::getRegisteredInterface const.

Where are you encountering a const Dialect?

I have this ExtensibleDialect class that extend Dialect (and that is used by multiple dialects). In order to cast a Dialect to an ExtensibleDialect, I retrieve an interface that is only implemented on ExtensibleDialect.
Since classof requires a const Dialect*, I cannot currently retrieve the interface in this function.

I would cast away the const wherever you are encountering it (if it is required there). Technically Dialect shouldn't have any const API(https://mlir.llvm.org/docs/Rationale/UsageOfConst/), but it looks like that is being broken in a few places.

Jun 24 2021, 10:57 AM · Restricted Project
math-fehr added a comment to D104862: [mlir] NFC: make Dialect::getRegisteredInterface const.

Where are you encountering a const Dialect?

Jun 24 2021, 10:52 AM · Restricted Project
math-fehr updated the summary of D104554: [mlir] Add extensible dialects.
Jun 24 2021, 8:53 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Add new useful methods on ExtensibleDialect.
Also, fix cast on ExtensibleDialect.

Jun 24 2021, 8:52 AM · Restricted Project, Restricted Project
math-fehr updated the diff for D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.

Fix formatting

Jun 24 2021, 8:28 AM · Restricted Project
math-fehr requested review of D104862: [mlir] NFC: make Dialect::getRegisteredInterface const.
Jun 24 2021, 8:23 AM · Restricted Project

Jun 23 2021

math-fehr resigned from D104534: [mlir] Add classes to define new TypeIDs at runtime.

Sorry, I think I added myself as a reviewer by mistake.

Jun 23 2021, 7:37 AM · Restricted Project

Jun 22 2021

math-fehr updated the diff for D104554: [mlir] Add extensible dialects.

Remove use of std::vector in favor of SmallVector

Jun 22 2021, 9:10 AM · Restricted Project, Restricted Project
math-fehr accepted D104534: [mlir] Add classes to define new TypeIDs at runtime.
Jun 22 2021, 7:39 AM · Restricted Project
math-fehr updated the diff for D104534: [mlir] Add classes to define new TypeIDs at runtime.

Fix spelling error

Jun 22 2021, 7:13 AM · Restricted Project
math-fehr updated the diff for D104534: [mlir] Add classes to define new TypeIDs at runtime.

Rename function, and use bump pointer allocator

Jun 22 2021, 7:04 AM · Restricted Project
math-fehr added reviewers for D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns: yrouban, chandlerc, vvereschaka, DaniilSuchkov.
Jun 22 2021, 5:17 AM · Restricted Project
math-fehr requested review of D104703: [ADT] Extend EnableIfCallable for callables with incomplete returns.
Jun 22 2021, 5:15 AM · Restricted Project

Jun 18 2021

math-fehr updated the summary of D104554: [mlir] Add extensible dialects.
Jun 18 2021, 11:00 AM · Restricted Project, Restricted Project