Details
Details
- Reviewers
tianshilei1992 jdoerfert
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Full details and reproducer at this GitHub issue: https://github.com/llvm/llvm-project/issues/60345
Comment Actions
I think this looks reasonable to me. @jdoerfert WDYT? I'm not sure if you need to fix some clang tests. Let's see if Buildbot is happy.
Comment Actions
Please use poison values as place holders instead of undef values as we're trying to get rid of Undef. Thank you!
Comment Actions
This needs a test (I would hope there is already one that needs updating), and also should switch to using PoisonValue instead of UndefValue
clang-format not found in user’s local PATH; not linting file.