This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fix build after D143339
ClosedPublic

Authored by springerm on Feb 22 2023, 5:21 AM.

Details

Summary

This change silences a compiler warning: base class should be explictily initialized in the copy constructor.

Diff Detail

Event Timeline

springerm created this revision.Feb 22 2023, 5:21 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 22 2023, 5:21 AM
Herald added a subscriber: hanchung. · View Herald Transcript
springerm requested review of this revision.Feb 22 2023, 5:21 AM

Nit: Could you add a line in the summary what this change does?

flang/include/flang/Optimizer/Builder/FIRBuilder.h
47

Is the same change required here?

springerm updated this revision to Diff 499472.Feb 22 2023, 6:27 AM
springerm marked an inline comment as done.

address comments

springerm edited the summary of this revision. (Show Details)Feb 22 2023, 6:28 AM
springerm edited the summary of this revision. (Show Details)
springerm added inline comments.
flang/include/flang/Optimizer/Builder/FIRBuilder.h
47

The build failure was due to a warning about the copy constructor. So it's probably not needed. But maybe better to add here as well.

This revision is now accepted and ready to land.Feb 22 2023, 7:23 AM
PeteSteinfeld accepted this revision.Feb 22 2023, 7:32 AM
PeteSteinfeld added a subscriber: PeteSteinfeld.

Thanks for doing this!

With this change, flang builds correctly and passes all tests.

This revision was automatically updated to reflect the committed changes.