This is an archive of the discontinued LLVM Phabricator instance.

Differential D144247

[mlir][llvm] Make DI param optional to match LLVM
ClosedPublic

Authored by Dinistro on Feb 17 2023, 2:08 AM.

Details

Reviewers
gysit
ftynse
nicolasvasilache
dcaballe
Commits
rG276358fd3af5: [mlir][llvm] Make DI param optional to match LLVM
Summary

This commit makes DIDerivedTypeAttr's baseType parameter optional to ensure imported IR
doesn't break the printer.

Diff Detail

Event Timeline

Dinistro created this revision.Feb 17 2023, 2:08 AM
Herald added a reviewer: ftynse. · View Herald TranscriptFeb 17 2023, 2:08 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
Dinistro requested review of this revision.Feb 17 2023, 2:08 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 17 2023, 2:08 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B214351: Diff 498289.Feb 17 2023, 2:25 AM
gysit accepted this revision.Feb 17 2023, 3:59 AM

LGTM

This revision is now accepted and ready to land.Feb 17 2023, 3:59 AM
Closed by commit rG276358fd3af5: [mlir][llvm] Make DI param optional to match LLVM (authored by Dinistro). · Explain WhyFeb 17 2023, 4:09 AM
This revision was automatically updated to reflect the committed changes.
Dinistro added a commit: rG276358fd3af5: [mlir][llvm] Make DI param optional to match LLVM.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
2 lines
test/
Dialect/
LLVMIR/
4 lines

Diff 498289

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

Show First 20 Lines • Show All 334 Lines • ▼ Show 20 Lines
// DIDerivedTypeAttr // DIDerivedTypeAttr
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def LLVM_DIDerivedTypeAttr : LLVM_Attr<"DIDerivedType", "di_derived_type", def LLVM_DIDerivedTypeAttr : LLVM_Attr<"DIDerivedType", "di_derived_type",
/*traits=*/[], "DITypeAttr"> { /*traits=*/[], "DITypeAttr"> {
let parameters = (ins let parameters = (ins
LLVM_DITagParameter:$tag, LLVM_DITagParameter:$tag,
OptionalParameter<"StringAttr">:$name, OptionalParameter<"StringAttr">:$name,
"DITypeAttr":$baseType, OptionalParameter<"DITypeAttr">:$baseType,
OptionalParameter<"uint64_t">:$sizeInBits, OptionalParameter<"uint64_t">:$sizeInBits,
OptionalParameter<"uint32_t">:$alignInBits, OptionalParameter<"uint32_t">:$alignInBits,
OptionalParameter<"uint64_t">:$offsetInBits OptionalParameter<"uint64_t">:$offsetInBits
); );
let assemblyFormat = "`<` struct(params) `>`"; let assemblyFormat = "`<` struct(params) `>`";
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 173 Lines • Show Last 20 Lines

mlir/test/Dialect/LLVMIR/debuginfo.mlir

Show All 24 Lines
> >
// CHECK-DAG: #[[PTR0:.*]] = #llvm.di_derived_type<tag = DW_TAG_pointer_type, baseType = #[[INT0]], sizeInBits = 64, alignInBits = 32, offsetInBits = 4> // CHECK-DAG: #[[PTR0:.*]] = #llvm.di_derived_type<tag = DW_TAG_pointer_type, baseType = #[[INT0]], sizeInBits = 64, alignInBits = 32, offsetInBits = 4>
#ptr0 = #llvm.di_derived_type< #ptr0 = #llvm.di_derived_type<
tag = DW_TAG_pointer_type, baseType = #int0, tag = DW_TAG_pointer_type, baseType = #int0,
sizeInBits = 64, alignInBits = 32, offsetInBits = 4 sizeInBits = 64, alignInBits = 32, offsetInBits = 4
> >
// CHECK-DAG: #[[PTR1:.*]] = #llvm.di_derived_type<tag = DW_TAG_pointer_type, name = "ptr1", baseType = #[[INT0]]> // CHECK-DAG: #[[PTR1:.*]] = #llvm.di_derived_type<tag = DW_TAG_pointer_type, name = "ptr1">
#ptr1 = #llvm.di_derived_type< #ptr1 = #llvm.di_derived_type<
// Specify the name parameter. // Specify the name parameter.
tag = DW_TAG_pointer_type, name = "ptr1", baseType = #int0 tag = DW_TAG_pointer_type, name = "ptr1"
> >
// CHECK-DAG: #[[COMP0:.*]] = #llvm.di_composite_type<tag = DW_TAG_array_type, name = "array0", line = 10, sizeInBits = 128, alignInBits = 32> // CHECK-DAG: #[[COMP0:.*]] = #llvm.di_composite_type<tag = DW_TAG_array_type, name = "array0", line = 10, sizeInBits = 128, alignInBits = 32>
#comp0 = #llvm.di_composite_type< #comp0 = #llvm.di_composite_type<
tag = DW_TAG_array_type, name = "array0", tag = DW_TAG_array_type, name = "array0",
line = 10, sizeInBits = 128, alignInBits = 32 line = 10, sizeInBits = 128, alignInBits = 32
> >
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines