- Extract the common code of some instructions into a class to reduce duplication
- Refine some comments to the make the description of the class clearer
By this way, the records defined here will be consistent and easier to
maintain, I think.
Paths
| Differential D144154
[X86][NFC] Refactor X86InstrArithmetic.td by class ClosedPublic Authored by XinWang10 on Feb 15 2023, 5:51 PM.
Details Summary
By this way, the records defined here will be consistent and easier to
Diff Detail
Unit TestsFailed Event Timeline
This revision is now accepted and ready to land.Feb 21 2023, 1:47 AM skan retitled this revision from [X86]Use Class to refactor ArithMetic td file in X86 to [X86][NFC] Refactor X86InstrArithmetic.td by class.Feb 21 2023, 1:52 AM This revision was landed with ongoing or failed builds.Feb 21 2023, 5:20 PM Closed by commit rG749318dbfb74: [X86][NFC] Refactor X86InstrArithmetic.td by class (authored by XinWang10, committed by skan). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 498250 llvm/lib/Target/X86/X86InstrArithmetic.td
|
This class looks common, could we move it to X86InstrFormats..td?