This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy][doc] Remove unused variable
ClosedPublic

Authored by bjosv on Feb 14 2023, 3:08 AM.

Details

Summary

Remove mention of a variable that is not used in the example for checker:
cppcoreguidelines-avoid-non-const-global-variables

Diff Detail

Event Timeline

bjosv created this revision.Feb 14 2023, 3:08 AM
Herald added a project: Restricted Project. · View Herald Transcript
bjosv requested review of this revision.Feb 14 2023, 3:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 3:08 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko requested changes to this revision.Feb 14 2023, 7:18 AM
Eugene.Zelenko added inline comments.
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst
34–35

Please fill as much of 80 symbols as possible.

This revision now requires changes to proceed.Feb 14 2023, 7:19 AM
bjosv updated this revision to Diff 497344.Feb 14 2023, 8:32 AM

Updated to fill 80 char as proposed, and changed some wordings.

Eugene.Zelenko accepted this revision.Feb 14 2023, 8:36 AM
This revision is now accepted and ready to land.Feb 14 2023, 8:36 AM
carlosgalvezp accepted this revision.Feb 14 2023, 10:47 AM

LGTM, thanks for the fix!

carlosgalvezp added a comment.EditedFeb 23 2023, 8:18 AM

@bjosv Are you able to land the patch yourself, or should we do it for you? If so, please provide user and email for Github attribution.

bjosv added a comment.EditedFeb 23 2023, 8:48 AM

@carlosgalvezp Sorry, I should have mentioned that I don't have push rights and that this is my first contribution to llvm.
My GitHub user is: bjosv and email: bjorn.a.svensson@est.tech
Thanks.

This revision was automatically updated to reflect the committed changes.

@carlosgalvezp Sorry, I should have mentioned that I don't have push rights and that this is my first contribution to llvm.
My GitHub user is: bjosv and email: bjorn.a.svensson@est.tech
Thanks.

No problem, thanks for your first contribution! :)