This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Reintroduce shared attribute names in the LLVM dialect
ClosedPublic

Authored by frgossen on Feb 10 2023, 12:25 PM.

Diff Detail

Event Timeline

frgossen created this revision.Feb 10 2023, 12:25 PM
Herald added a project: Restricted Project. · View Herald Transcript
frgossen requested review of this revision.Feb 10 2023, 12:25 PM
gysit accepted this revision.Feb 10 2023, 12:28 PM
gysit added inline comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
42

I think this should now be just tbaa since this is not a dialect attribute anymore?

This revision is now accepted and ready to land.Feb 10 2023, 12:28 PM
frgossen updated this revision to Diff 496588.Feb 10 2023, 1:12 PM

Address comment

mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
42

Turns out we don't need that one. Thanks!

This revision was landed with ongoing or failed builds.Feb 10 2023, 1:20 PM
This revision was automatically updated to reflect the committed changes.