This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Add missing newline to "image lookup" output
ClosedPublic

Authored by DavidSpickett on Feb 8 2023, 2:30 AM.

Details

Summary

When using --name, due to a missing newline, multiple symbol results
were not correctly printed:

(lldb) image lookup -r -n "As<.*"
2 matches found in <...>/tbi_lisp:
        Address: tbi_lisp<...>
        Summary: tbi_lisp<...> at Symbol.cpp:75        Address: tbi_lisp<...>
        Summary: tbi_lisp<...> at Symbol.cpp:82

It should be:

(lldb) image lookup -r -n "As<.*"
2 matches found in /home/david.spickett/tbi_lisp/tbi_lisp:
        Address: tbi_lisp<...>
        Summary: tbi_lisp<...> at Symbol.cpp:75
        Address: tbi_lisp<...>
        Summary: tbi_lisp<...> at Symbol.cpp:82

With Address/Summary on separate lines.

Diff Detail

Event Timeline

DavidSpickett created this revision.Feb 8 2023, 2:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 2:30 AM
DavidSpickett requested review of this revision.Feb 8 2023, 2:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 2:30 AM
labath accepted this revision.Feb 8 2023, 9:25 AM
This revision is now accepted and ready to land.Feb 8 2023, 9:25 AM
clayborg accepted this revision.Feb 8 2023, 11:24 AM
This revision was automatically updated to reflect the committed changes.