Page MenuHomePhabricator
Differential D143472

[clang] Cast the pointer to right type with different address space
Needs ReviewPublic
Actions

Authored by cdai2 on Feb 7 2023, 12:37 AM.

Details

Reviewers
Anastasia
Summary

The source type has OpenCL general address space but dest type does
not have address space. Address space cast is needed for this scenario.

Diff Detail

Unit TestsFailed
View All

TimeTest
620 msx64 debian > Clang.Driver::rocm-detect.hip
Script: -- : 'RUN: at line 10'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -### -v -target x86_64-linux-gnu --cuda-gpu-arch=gfx902 --rocm-path=/var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/Inputs/rocm /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/rocm-detect.hip 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -check-prefixes=COMMON,GFX902-DEFAULTLIBS /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/rocm-detect.hip

Event Timeline

cdai2 created this revision.Feb 7 2023, 12:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 12:37 AM
Herald added subscribers: pengfei, arichardson, Anastasia. · View Herald Transcript
cdai2 requested review of this revision.Feb 7 2023, 12:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 12:37 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B212294: Diff 495402.Feb 7 2023, 1:45 AM
cdai2 updated this revision to Diff 496033.Feb 8 2023, 11:36 PM

[clang] update test case

Harbormaster completed remote builds in B212748: Diff 496033.Feb 9 2023, 12:10 AM
cdai2 updated this revision to Diff 496275.Feb 9 2023, 4:16 PM

Update cases to cover both opaque pointer and typed pointer

bader added a reviewer: Anastasia.Feb 9 2023, 5:07 PM
Harbormaster completed remote builds in B212923: Diff 496275.Feb 9 2023, 6:51 PM
Anastasia added inline comments.Feb 12 2023, 12:55 PM
clang/lib/CodeGen/CGBuiltin.cpp
12412

I think the semantics of builtin functions is that they accept any address space. So you should preserve the address space from Ops[1].

Revision Contents
Changeset List

PathSize
clang/
lib/
CodeGen/
8 lines
test/
CodeGen/
X86/
67 lines
69 lines

Diff 496275

View Options

clang/lib/CodeGen/CGBuiltin.cpp

Loading...
View Options

clang/test/CodeGen/X86/x86-builtins-intrinsic-opaqueptr.cl

Loading...
View Options

clang/test/CodeGen/X86/x86-builtins-intrinsic-typedptr.cl

Loading...