This is an archive of the discontinued LLVM Phabricator instance.

Differential D143370

[mlir][llvm] Drop opaque ptr test in LLVM IR import.
ClosedPublic

Authored by gysit on Feb 5 2023, 11:32 PM.

Details

Reviewers
ftynse
dcaballe
Dinistro
Commits
rG7dd974a11532: [mlir][llvm] Drop opaque ptr test in LLVM IR import.
Summary

After switching all LLVM IR import tests to opaque pointers
the specialized opaque pointer test file is redundant.

Diff Detail

Event Timeline

gysit created this revision.Feb 5 2023, 11:32 PM
Herald added a reviewer: ftynse. · View Herald TranscriptFeb 5 2023, 11:32 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 23 others. · View Herald Transcript
gysit requested review of this revision.Feb 5 2023, 11:32 PM
Herald added a reviewer: dcaballe. · View Herald TranscriptFeb 5 2023, 11:32 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
gysit added a reviewer: Dinistro.Feb 5 2023, 11:32 PM
Dinistro accepted this revision.Feb 5 2023, 11:53 PM

LGTM!

This revision is now accepted and ready to land.Feb 5 2023, 11:53 PM
Harbormaster completed remote builds in B212007: Diff 495006.Feb 6 2023, 12:25 AM
Closed by commit rG7dd974a11532: [mlir][llvm] Drop opaque ptr test in LLVM IR import. (authored by gysit). · Explain WhyFeb 6 2023, 1:20 AM
This revision was automatically updated to reflect the committed changes.
gysit added a commit: rG7dd974a11532: [mlir][llvm] Drop opaque ptr test in LLVM IR import..

Revision Contents

PathSize
mlir/
test/
Target/
LLVMIR/
Import/
4 lines

Diff 495027

mlir/test/Target/LLVMIR/Import/instructions.ll

Show First 20 Lines • Show All 442 Lines • ▼ Show 20 Lines
} }
; // ----- ; // -----
; CHECK-LABEL: @gep_static_idx ; CHECK-LABEL: @gep_static_idx
; CHECK-SAME: %[[PTR:[a-zA-Z0-9]+]] ; CHECK-SAME: %[[PTR:[a-zA-Z0-9]+]]
define void @gep_static_idx(ptr %ptr) { define void @gep_static_idx(ptr %ptr) {
; CHECK: %[[IDX:.+]] = llvm.mlir.constant(7 : i32) ; CHECK: %[[IDX:.+]] = llvm.mlir.constant(7 : i32)
; CHECK: llvm.getelementptr inbounds %[[PTR]][%[[IDX]]] : (!llvm.ptr, i32) -> !llvm.ptr ; CHECK: llvm.getelementptr inbounds %[[PTR]][%[[IDX]]] : (!llvm.ptr, i32) -> !llvm.ptr, f32
%1 = getelementptr inbounds float, ptr %ptr, i32 7 %1 = getelementptr inbounds float, ptr %ptr, i32 7
ret void ret void
} }
; // ----- ; // -----
; CHECK: @varargs(...) ; CHECK: @varargs(...)
declare void @varargs(...) declare void @varargs(...)
Show All 11 Lines
%sub_struct = type { i32, i8 } %sub_struct = type { i32, i8 }
%my_struct = type { %sub_struct, [4 x i32] } %my_struct = type { %sub_struct, [4 x i32] }
; CHECK-LABEL: @gep_dynamic_idx ; CHECK-LABEL: @gep_dynamic_idx
; CHECK-SAME: %[[PTR:[a-zA-Z0-9]+]] ; CHECK-SAME: %[[PTR:[a-zA-Z0-9]+]]
; CHECK-SAME: %[[IDX:[a-zA-Z0-9]+]] ; CHECK-SAME: %[[IDX:[a-zA-Z0-9]+]]
define void @gep_dynamic_idx(ptr %ptr, i32 %idx) { define void @gep_dynamic_idx(ptr %ptr, i32 %idx) {
; CHECK: %[[C0:.+]] = llvm.mlir.constant(0 : i32) ; CHECK: %[[C0:.+]] = llvm.mlir.constant(0 : i32)
; CHECK: llvm.getelementptr %[[PTR]][%[[C0]], 1, %[[IDX]]] ; CHECK: llvm.getelementptr %[[PTR]][%[[C0]], 1, %[[IDX]]]{{.*}}"my_struct"
%1 = getelementptr %my_struct, ptr %ptr, i32 0, i32 1, i32 %idx %1 = getelementptr %my_struct, ptr %ptr, i32 0, i32 1, i32 %idx
ret void ret void
} }
; // ----- ; // -----
; CHECK-LABEL: @freeze ; CHECK-LABEL: @freeze
; CHECK-SAME: %[[ARG1:[a-zA-Z0-9]+]] ; CHECK-SAME: %[[ARG1:[a-zA-Z0-9]+]]
Show All 29 Lines

mlir/test/Target/LLVMIR/Import/opaque.ll

  • This file was deleted.
; RUN: mlir-translate -import-llvm -split-input-file -opaque-pointers %s | FileCheck %s
; CHECK-LABEL: @opaque_ptr_load
define i32 @opaque_ptr_load(ptr %0) {
; CHECK: = llvm.load %{{.*}} : !llvm.ptr -> i32
%2 = load i32, ptr %0, align 4
ret i32 %2
}
; // -----
; CHECK-LABEL: @opaque_ptr_store
define void @opaque_ptr_store(i32 %0, ptr %1) {
; CHECK: llvm.store %{{.*}}, %{{.*}} : i32, !llvm.ptr
store i32 %0, ptr %1, align 4
ret void
}
; // -----
; CHECK-LABEL: @opaque_ptr_ptr_store
define void @opaque_ptr_ptr_store(ptr %0, ptr %1) {
; CHECK: llvm.store %{{.*}}, %{{.*}} : !llvm.ptr, !llvm.ptr
store ptr %0, ptr %1, align 8
ret void
}
; // -----
; CHECK-LABEL: @opaque_ptr_alloca
define ptr @opaque_ptr_alloca(i32 %0) {
; CHECK: = llvm.alloca %{{.*}} x f32 {alignment = 4 : i64} : (i32) -> !llvm.ptr
%2 = alloca float, i32 %0, align 4
ret ptr %2
}
; // -----
; CHECK-LABEL: @opaque_ptr_gep
define ptr @opaque_ptr_gep(ptr %0, i32 %1) {
; CHECK: = llvm.getelementptr inbounds %{{.*}}[%{{.*}}] : (!llvm.ptr, i32) -> !llvm.ptr, f32
%3 = getelementptr inbounds float, ptr %0, i32 %1
ret ptr %3
}
; // -----
; CHECK-LABEL: @opaque_ptr_gep
define ptr @opaque_ptr_gep_struct(ptr %0, i32 %1){
; CHECK: = llvm.getelementptr %{{.*}}[%{{.*}}, 0, 1] : (!llvm.ptr, i32) -> !llvm.ptr, !llvm.struct<(struct<(f32, f64)>, struct<(i32, i64)>)>
%3 = getelementptr { { float, double }, { i32, i64 } }, ptr %0, i32 %1, i32 0, i32 1
ret ptr %3
}
mlir/test/Target/LLVMIR/Import/instructions.ll