Page MenuHomePhabricator
Differential D143277

[SME2][AArch64] Add multi-multi multiply-add long long intrinsics
ClosedPublic
Actions

Authored by kmclaughlin on Feb 3 2023, 8:58 AM.

Details

Reviewers
sdesmalen
david-arm
CarolineConcatto
aemerson
Commits
rG028c722ac8ea: [SME2][AArch64] Add multi-multi multiply-add long long intrinsics
Summary

Adds intrinsics for the following SME2 instructions (2 & 4 vectors):

  • smlall
  • smlsll
  • umlall
  • umlsll
  • usmlall
NOTE: These intrinsics are still in development and are subject to future changes.

Diff Detail

Event Timeline

kmclaughlin created this revision.Feb 3 2023, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2023, 8:58 AM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
kmclaughlin requested review of this revision.Feb 3 2023, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2023, 8:58 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kmclaughlin added a parent revision: D143276: [SME2][AArch64] Add multi-single multiply-add long long intrinsics.Feb 3 2023, 8:58 AM
Harbormaster completed remote builds in B211747: Diff 494666.Feb 3 2023, 10:59 AM
david-arm added inline comments.Feb 9 2023, 5:25 AM
llvm/lib/Target/AArch64/SMEInstrFormats.td
2818

Again, same suggestion as here https://reviews.llvm.org/D143276#inline-1386660, but feel free to ignore this if it doesn't make it any better!

kmclaughlin added inline comments.Feb 15 2023, 9:41 AM
llvm/lib/Target/AArch64/SMEInstrFormats.td
2818

I think in this case it will not reduce much because the VG2 & VG4 instructions have to use separate classes (sme2_mla_ll_array_vg2_multi and sme2_mla_ll_array_vg4_multi)?

david-arm accepted this revision.Feb 16 2023, 5:16 AM

LGTM!

llvm/lib/Target/AArch64/SMEInstrFormats.td
2818

Fair point, silly me!

This revision is now accepted and ready to land.Feb 16 2023, 5:16 AM
Closed by commit rG028c722ac8ea: [SME2][AArch64] Add multi-multi multiply-add long long intrinsics (authored by kmclaughlin). · Explain WhyMon, Feb 20, 6:02 AM
This revision was automatically updated to reflect the committed changes.
kmclaughlin added a commit: rG028c722ac8ea: [SME2][AArch64] Add multi-multi multiply-add long long intrinsics.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
IR/
6 lines
lib/
Target/
AArch64/
36 lines
18 lines
test/
CodeGen/
AArch64/
398 lines

Diff 498819

View Options

llvm/include/llvm/IR/IntrinsicsAArch64.td

Loading...
View Options

llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td

Loading...
View Options

llvm/lib/Target/AArch64/SMEInstrFormats.td

Loading...
View Options

llvm/test/CodeGen/AArch64/sme2-intrinsics-mlall.ll

Loading...