This is an archive of the discontinued LLVM Phabricator instance.

[mlir][llvm] Import access group metadata.

Authored by gysit on Jan 26 2023, 12:17 AM.



The revision adds support to import access group metadata from LLVM IR.
It closely follows the design of the TBAA metadata import with an
up-front conversion of the metadata nodes to operations stored in the
body of a module-level metadata operation. The revision chooses to use
only one module-level metadata operation for all kinds of metadata.
This design ensures there is only one metadata operation that pollutes
the user namespace.

The import of loop metadata, which will use the access groups,
is left to a follow up revision.

Diff Detail

Event Timeline

gysit created this revision.Jan 26 2023, 12:17 AM
Herald added a project: Restricted Project. · View Herald Transcript
gysit requested review of this revision.Jan 26 2023, 12:17 AM
Dinistro added inline comments.Jan 26 2023, 8:46 AM

should we maybe prefix this with "llvm." and add to the LLVMDialect? I assume that this will also be used for the export at some point.

Dinistro accepted this revision.Jan 27 2023, 1:44 AM


This revision is now accepted and ready to land.Jan 27 2023, 1:44 AM
gysit updated this revision to Diff 493287.Jan 30 2023, 5:30 AM

Address review comment and rebase.

This revision was automatically updated to reflect the committed changes.