This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME2] NFC: Simplify multiclasses for mova/movaz.
ClosedPublic

Authored by sdesmalen on Jan 20 2023, 3:55 AM.

Diff Detail

Event Timeline

sdesmalen created this revision.Jan 20 2023, 3:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 3:55 AM
sdesmalen requested review of this revision.Jan 20 2023, 3:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 3:55 AM
CarolineConcatto accepted this revision.Jan 23 2023, 1:47 AM

Thank you Sander for the patch!
IMHO it is ok to simplify the classes, as far as all the alias are still there.
I just would add the comments we had before on top of the multiclasses.
But besides that I see no problem.

llvm/lib/Target/AArch64/SMEInstrFormats.td
3508–3509

I think that the comments should be on top of the multi-class, not here.

3600–3601

Maybe add:
SME2 move tile to vector, two register

3606–3607

Maybe add:
// SME2.1 zeroing move tile to vector, two registers

This revision is now accepted and ready to land.Jan 23 2023, 1:47 AM
This revision was landed with ongoing or failed builds.Jan 23 2023, 5:11 AM
This revision was automatically updated to reflect the committed changes.
sdesmalen marked 3 inline comments as done.Jan 23 2023, 5:11 AM