Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thank you Sander for the patch!
IMHO it is ok to simplify the classes, as far as all the alias are still there.
I just would add the comments we had before on top of the multiclasses.
But besides that I see no problem.
llvm/lib/Target/AArch64/SMEInstrFormats.td | ||
---|---|---|
3508–3509 | I think that the comments should be on top of the multi-class, not here. | |
3600–3601 | Maybe add: | |
3606–3607 | Maybe add: |
I think that the comments should be on top of the multi-class, not here.