These instantiations were never visible, because they are only used in __sort, which is also explicitly instantiated in the dylib.
Details
Details
- Reviewers
ldionne Mordante var-const huixie90 - Group Reviewers
Restricted Project - Commits
- rG97b5e0147c6f: [libc++] Remove explicit instantiations of __insertion_sort_incomplete and…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Adding #libc_vendors for awareness. In case anybody has a way of checking whether some application is relying on these symbols it would also be nice to have confirmation that there is indeed nobody relying on them.
Comment Actions
LGTM. This is safe in theory, and I can confirm that I didn't find any program relying on these symbols on our platform -- so this seems to be safe in practice too. Also, this is landing early in the LLVM 17 cycle, so we should have plenty of time to discover issues in case there are any (but I really don't expect anything).