This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove explicit instantiations of __insertion_sort_incomplete and __sort5 from the dylib
ClosedPublic

Authored by philnik on Jan 20 2023, 12:18 AM.

Details

Summary

These instantiations were never visible, because they are only used in __sort, which is also explicitly instantiated in the dylib.

Diff Detail

Event Timeline

philnik created this revision.Jan 20 2023, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 12:18 AM
philnik requested review of this revision.Jan 20 2023, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 12:18 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik added a subscriber: Restricted Project.Jan 20 2023, 12:22 AM

Adding #libc_vendors for awareness. In case anybody has a way of checking whether some application is relying on these symbols it would also be nice to have confirmation that there is indeed nobody relying on them.

ldionne accepted this revision.Feb 1 2023, 9:08 AM

LGTM. This is safe in theory, and I can confirm that I didn't find any program relying on these symbols on our platform -- so this seems to be safe in practice too. Also, this is landing early in the LLVM 17 cycle, so we should have plenty of time to discover issues in case there are any (but I really don't expect anything).

This revision is now accepted and ready to land.Feb 1 2023, 9:08 AM