This is an archive of the discontinued LLVM Phabricator instance.

[mlir][LLVM] Add passthrough import support

Authored by Dinistro on Jan 19 2023, 2:27 AM.



This commit extends the LLVMIR import to support function attributes by
adding them to the passthrough array attribute.

Depends on D142013

Diff Detail

Event Timeline

Dinistro created this revision.Jan 19 2023, 2:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
Dinistro requested review of this revision.Jan 19 2023, 2:27 AM
gysit accepted this revision.Jan 19 2023, 5:53 AM

Nice, LGTM modulo comments!


nit: a->attr or funcAttr?


nit: hande -> handle maybe say "Skip the memory attribute since the funcOp has an explicit memory attribute."


let's use llvm_unreachable here?


nit: time to remove the FIXME :)?

This revision is now accepted and ready to land.Jan 19 2023, 5:53 AM
Dinistro updated this revision to Diff 490489.Jan 19 2023, 6:12 AM
Dinistro marked 4 inline comments as done.

address review comments

Dinistro updated this revision to Diff 490493.Jan 19 2023, 6:24 AM

change unreachable message

This revision was automatically updated to reflect the committed changes.