[BOLT] Handle __uniq suffix added by -funique-internal-linkage-names

[Amir]

Summary

In profile matching, if .__uniq suffix added for internal linkage
symbols with -funique-internal-linkage-names prevents BOLT from
matching to a binary function, try to strip the suffix and perform
fuzzy name matching.

Follow-up to D124117.

[Amir]

bugfix

[Amir]

Remove hasVolatileName changes

[maksfb]

Nice! Could you add a summary and a test case to bolt/test/X86/lto-name-match.s?

[Amir]

Update lto-name-match.s

bolt/lib/Profile/DataReader.cpp

DumpData("dump-data",
   cl::cat(BoltCategory));
 
 } // namespace opts
 
 namespace llvm {
 namespace bolt {
 
 std::optional<StringRef> getLTOCommonName(const StringRef Name) {
-  size_t LTOSuffixPos = Name.find(".lto_priv.");
+  for (StringRef Suffix : {".__uniq.", ".lto_priv.", ".constprop.", ".llvm."}) {
+    size_t LTOSuffixPos = Name.find(Suffix);
     if (LTOSuffixPos != StringRef::npos)
-    return Name.substr(0, LTOSuffixPos + 10);
-  if ((LTOSuffixPos = Name.find(".constprop.")) != StringRef::npos)
-    return Name.substr(0, LTOSuffixPos + 11);
-  if ((LTOSuffixPos = Name.find(".llvm.")) != StringRef::npos)
-    return Name.substr(0, LTOSuffixPos + 6);
+      return Name.substr(0, LTOSuffixPos + Suffix.size());
+  }
   return std::nullopt;
 }
 
 namespace {
 
 /// Return true if the function name can change across compilations.
 bool hasVolatileName(const BinaryFunction &BF) {
-  for (const StringRef &Name : BF.getNames())
-    if (getLTOCommonName(Name))
-      return true;
-
-  return false;
+  return llvm::any_of(BF.getNames(), getLTOCommonName);
 }
 
 /// Return standard escaped name of the function possibly renamed by BOLT.
 std::string normalizeName(StringRef NameRef) {
   // Strip "PG." prefix used for globalized locals.
   NameRef = NameRef.startswith("PG.") ? NameRef.substr(2) : NameRef;
   return getEscapedName(NameRef);
 }