[flang] Add TODO for allocate array with scalar source

[peixin]

Summary

This scenario is not supported yet.

[clementval]

Thanks @peixin LGTM

[DavidTruby]

This appears to be breaking the buildbots (and causing failures for me locally), for example here: https://lab.llvm.org/buildbot/#/builders/160/builds/15142. Could we revert until it can be fixed?

[clementval]

In D141932#4062288, @DavidTruby wrote:

This appears to be breaking the buildbots (and causing failures for me locally), for example here: https://lab.llvm.org/buildbot/#/builders/160/builds/15142. Could we revert until it can be fixed?

Should be fixed with d35c7e413c8ff41543c3e009fabc429446ffdf17. TODO was not at the right place. Feel free to revert both commit if it is still failing.

[peixin]

In D141932#4062316, @clementval wrote:

In D141932#4062288, @DavidTruby wrote:

This appears to be breaking the buildbots (and causing failures for me locally), for example here: https://lab.llvm.org/buildbot/#/builders/160/builds/15142. Could we revert until it can be fixed?

Should be fixed with d35c7e413c8ff41543c3e009fabc429446ffdf17. TODO was not at the right place. Feel free to revert both commit if it is still failing.

Sorry for the problem. Thanks @clementval . It was caused when I apply this patch on new main. It should be fixed now.

flang/lib/Lower/Allocatable.cpp

void genAllocateObjectBounds(const Allocation &alloc,
     }
   }
 
   void genSourceAllocation(const Allocation &alloc,
                            const fir::MutableBoxValue &box) {
     // Generate a sequence of runtime calls.
     errorManager.genStatCheck(builder, loc);
     genAllocateObjectInit(box);
+    if (alloc.getShapeSpecs().size() > 0 && sourceExv.rank() == 0)
+      TODO(loc, "allocate array object with scalar SOURCE specifier");
     if (alloc.hasCoarraySpec())
       TODO(loc, "coarray allocation");
     if (alloc.type.IsPolymorphic())
       TODO(loc, "polymorphic allocation with SOURCE specifier");
     // Set length of the allocate object if it has. Otherwise, get the length
     // from source for the deferred length parameter.
     if (lenParams.empty() && box.isCharacter() &&
         !box.hasNonDeferredLenParams())