This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add TODO for allocate array with scalar source
ClosedPublic

Authored by peixin on Jan 17 2023, 6:51 AM.

Details

Diff Detail

Event Timeline

peixin created this revision.Jan 17 2023, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 6:51 AM
peixin requested review of this revision.Jan 17 2023, 6:51 AM
clementval accepted this revision.Jan 17 2023, 7:02 AM

Thanks @peixin LGTM

This revision is now accepted and ready to land.Jan 17 2023, 7:02 AM
jeanPerier accepted this revision.Jan 17 2023, 7:21 AM
sscalpone accepted this revision.Jan 17 2023, 9:41 AM
This revision was automatically updated to reflect the committed changes.

This appears to be breaking the buildbots (and causing failures for me locally), for example here: https://lab.llvm.org/buildbot/#/builders/160/builds/15142. Could we revert until it can be fixed?

This appears to be breaking the buildbots (and causing failures for me locally), for example here: https://lab.llvm.org/buildbot/#/builders/160/builds/15142. Could we revert until it can be fixed?

Should be fixed with d35c7e413c8ff41543c3e009fabc429446ffdf17. TODO was not at the right place. Feel free to revert both commit if it is still failing.

This appears to be breaking the buildbots (and causing failures for me locally), for example here: https://lab.llvm.org/buildbot/#/builders/160/builds/15142. Could we revert until it can be fixed?

Should be fixed with d35c7e413c8ff41543c3e009fabc429446ffdf17. TODO was not at the right place. Feel free to revert both commit if it is still failing.

Sorry for the problem. Thanks @clementval . It was caused when I apply this patch on new main. It should be fixed now.