Differential D141918

WIP: [Clang] Emit 'unwindabort' when applicable.
Needs ReviewPublic
Actions

Authored by jyknight on Jan 17 2023, 3:53 AM.

Tags

Subscribers

Details

Reviewers

Summary

Now that the core codegen support has been implemented in LLVM, we can
start using it in Clang.

This allows us to generate more efficient and smaller code for
'noexcept' functions.

For now, we only enable this for the Itanium EH handling,
_gxx_personality_v0 and _objc_personality_v0, as LLVM support is still
incomplete for other exception-handling schemes.

Depends on D141917

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	70 ms	x64 debian > LLVM.CodeGen/X86::unwindabort-inline-asm-codegen.ll Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -fast-isel=0 < /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/X86/unwindabort-inline-asm-codegen.ll \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/X86/unwindabort-inline-asm-codegen.ll

Event Timeline

jyknight created this revision.Jan 17 2023, 3:53 AM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 17 2023, 3:53 AM

Herald added subscribers: cfe-commits, mstorsjo. · View Herald Transcript

jyknight requested review of this revision.Jan 17 2023, 3:53 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 17 2023, 3:53 AM

Herald added a subscriber: sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B208207: Diff 489761.Jan 17 2023, 5:36 AM

I couldn't find an example of creating "resume unwindabort" in the patch series. Is it yet to be done?
Could you show a source code example where such an instruction should be generated? (By the frontend or an IR pass.) I couldn't get it from the RFC.

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

37 lines

17 lines

8 lines

CGException.cpp

28 lines

2 lines

CodeGenFunction.h

7 lines

3 lines

test/

CXX/

except/

except.spec/

7 lines

p9-noexcept.cpp

15 lines

CodeGenCXX/

arm-generated-fn-attr.cpp

6 lines

block-byref-cxx-objc.cpp

2 lines

cxx0x-delegating-ctors.cpp

10 lines

debug-info-class.cpp

3 lines

debug-info-line.cpp

9 lines

destructors.cpp

19 lines

dllimport-runtime-fns.cpp

22 lines

2 lines

44 lines

lambda-expressions.cpp

3 lines

20 lines

830 lines

partial-destruction.cpp

12 lines

pod-member-memcpys.cpp

2 lines

11 lines

rtti-qualfn.cpp

4 lines

runtime-dllstorage.cpp

5 lines

CodeGenObjCXX/

18 lines

12 lines

OpenMP/

atomic_codegen.cpp

47 lines

critical_codegen.cpp

12 lines

critical_codegen_attr.cpp

17 lines

declare_reduction_codegen.cpp

2 lines

distribute_parallel_for_num_threads_codegen.cpp

452 lines

distribute_parallel_for_simd_num_threads_codegen.cpp

818 lines

for_codegen.cpp

18 lines

for_simd_codegen.cpp

16 lines

masked_codegen.cpp

18 lines

master_codegen.cpp

10 lines

ordered_doacross_codegen.cpp

12 lines

parallel_codegen.cpp

106 lines

parallel_for_codegen.cpp

51 lines

parallel_for_simd_codegen.cpp

19 lines

parallel_master_codegen.cpp

17 lines

parallel_sections_codegen.cpp

33 lines

sections_codegen.cpp

10 lines

simd_codegen.cpp

17 lines

single_codegen.cpp

300 lines

taskgroup_codegen.cpp

62 lines

teams_distribute_parallel_for_num_threads_codegen.cpp

222 lines

teams_distribute_parallel_for_simd_num_threads_codegen.cpp

441 lines

Diff 489761

clang/lib/CodeGen/CGCall.cpp

Loading...

clang/lib/CodeGen/CGCleanup.h

Loading...

clang/lib/CodeGen/CGCleanup.cpp

Loading...

clang/lib/CodeGen/CGException.cpp

Loading...

clang/lib/CodeGen/CGObjC.cpp

Loading...

clang/lib/CodeGen/CodeGenFunction.h

Loading...

clang/lib/CodeGen/EHScopeStack.h

Loading...

clang/test/CXX/except/except.spec/p9-dynamic.cpp

Loading...

clang/test/CXX/except/except.spec/p9-noexcept.cpp

Loading...

clang/test/CodeGenCXX/arm-generated-fn-attr.cpp

Loading...

clang/test/CodeGenCXX/block-byref-cxx-objc.cpp

Loading...

clang/test/CodeGenCXX/cxx0x-delegating-ctors.cpp

Loading...

clang/test/CodeGenCXX/debug-info-class.cpp

Loading...

clang/test/CodeGenCXX/debug-info-line.cpp

Loading...

clang/test/CodeGenCXX/destructors.cpp

Loading...

clang/test/CodeGenCXX/dllimport-runtime-fns.cpp

Loading...

clang/test/CodeGenCXX/eh.cpp

Loading...

clang/test/CodeGenCXX/exceptions.cpp

Loading...

clang/test/CodeGenCXX/lambda-expressions.cpp

Loading...

clang/test/CodeGenCXX/noexcept.cpp

Loading...

clang/test/CodeGenCXX/nrvo.cpp

Loading...

clang/test/CodeGenCXX/partial-destruction.cpp

Loading...

clang/test/CodeGenCXX/pod-member-memcpys.cpp

Loading...

clang/test/CodeGenCXX/pr58798.cpp

Loading...

clang/test/CodeGenCXX/rtti-qualfn.cpp

Loading...

clang/test/CodeGenCXX/runtime-dllstorage.cpp

Loading...

clang/test/CodeGenObjCXX/arc-blocks.mm

Loading...

clang/test/CodeGenObjCXX/literals.mm

Loading...

clang/test/OpenMP/atomic_codegen.cpp

Loading...

clang/test/OpenMP/critical_codegen.cpp

Loading...

clang/test/OpenMP/critical_codegen_attr.cpp

Loading...

clang/test/OpenMP/declare_reduction_codegen.cpp

Loading...

clang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp

Loading...

clang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp

Loading...

clang/test/OpenMP/for_codegen.cpp

Loading...

clang/test/OpenMP/for_simd_codegen.cpp

Loading...

clang/test/OpenMP/masked_codegen.cpp

Loading...

clang/test/OpenMP/master_codegen.cpp

Loading...

clang/test/OpenMP/ordered_doacross_codegen.cpp

Loading...

clang/test/OpenMP/parallel_codegen.cpp

Loading...

clang/test/OpenMP/parallel_for_codegen.cpp

Loading...

clang/test/OpenMP/parallel_for_simd_codegen.cpp

Loading...

clang/test/OpenMP/parallel_master_codegen.cpp

Loading...

clang/test/OpenMP/parallel_sections_codegen.cpp

Loading...

clang/test/OpenMP/sections_codegen.cpp

Loading...

clang/test/OpenMP/simd_codegen.cpp

Loading...

clang/test/OpenMP/single_codegen.cpp

Loading...

clang/test/OpenMP/taskgroup_codegen.cpp

Loading...

clang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp

Loading...

clang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp

Loading...