This is an archive of the discontinued LLVM Phabricator instance.

Differential D141889

[OpenMP] Fix the wrong format string used in `__kmpc_error`
ClosedPublic

Authored by tianshilei1992 on Jan 16 2023, 8:44 PM.

Details

Reviewers
jdoerfert
hbae
AndreyChurbanov
protze.joachim
jlpeyton
Commits
rG4e27097c5bfb: [OpenMP] Fix the wrong format string used in `__kmpc_error`
Summary

This patch fixes the wrong format string used in __kmpc_error, which could
cause segment fault at runtime.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 16 2023, 8:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 8:44 PM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
tianshilei1992 requested review of this revision.Jan 16 2023, 8:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2023, 8:44 PM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B208150: Diff 489690.Jan 16 2023, 8:47 PM
jlpeyton accepted this revision.Jan 16 2023, 8:50 PM
jlpeyton added a subscriber: jlpeyton.

LGTM

This revision is now accepted and ready to land.Jan 16 2023, 8:50 PM
Closed by commit rG4e27097c5bfb: [OpenMP] Fix the wrong format string used in `__kmpc_error` (authored by tianshilei1992). · Explain WhyJan 16 2023, 8:55 PM
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rG4e27097c5bfb: [OpenMP] Fix the wrong format string used in `__kmpc_error`.

Revision Contents

PathSize
openmp/
runtime/
src/
2 lines

Diff 489690

openmp/runtime/src/kmp_csupport.cpp

Show First 20 Lines • Show All 4,447 Lines • ▼ Show 20 Lines ompt_callbacks.ompt_callback(ompt_callback_error)(
OMPT_GET_RETURN_ADDRESS(0)); OMPT_GET_RETURN_ADDRESS(0));
} }
#endif // OMPT_SUPPORT #endif // OMPT_SUPPORT
char *src_loc; char *src_loc;
if (loc && loc->psource) { if (loc && loc->psource) {
kmp_str_loc_t str_loc = __kmp_str_loc_init(loc->psource, false); kmp_str_loc_t str_loc = __kmp_str_loc_init(loc->psource, false);
src_loc = src_loc =
__kmp_str_format("%s:%s:%s", str_loc.file, str_loc.line, str_loc.col); __kmp_str_format("%s:%d:%d", str_loc.file, str_loc.line, str_loc.col);
__kmp_str_loc_free(&str_loc); __kmp_str_loc_free(&str_loc);
} else { } else {
src_loc = __kmp_str_format("unknown"); src_loc = __kmp_str_format("unknown");
} }
if (severity == severity_warning) if (severity == severity_warning)
KMP_WARNING(UserDirectedWarning, src_loc, message); KMP_WARNING(UserDirectedWarning, src_loc, message);
else else
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines