This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][GISel] Select sync instructions required by atomic operations
ClosedPublic

Authored by lkail on Jan 10 2023, 12:35 AM.

Details

Summary

This is part of selecting G_ATOMIC* instructions. Select isync, sync and lwsync in GISel.

Diff Detail

Event Timeline

lkail created this revision.Jan 10 2023, 12:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2023, 12:35 AM
lkail requested review of this revision.Jan 10 2023, 12:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2023, 12:35 AM
arsenm added inline comments.Jan 10 2023, 5:50 AM
llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp
725 ↗(On Diff #487712)

These should be trivially auto-selected from tablegen

lkail updated this revision to Diff 487790.Jan 10 2023, 6:50 AM

@arsenm Much appreciated for the suggestion.

arsenm accepted this revision.Jan 10 2023, 6:50 AM
This revision is now accepted and ready to land.Jan 10 2023, 6:50 AM
tschuett added inline comments.
llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.cpp
179

compute value

179

check every operand

lkail updated this revision to Diff 487800.Jan 10 2023, 7:20 AM
lkail marked 2 inline comments as done.
This revision was landed with ongoing or failed builds.Jan 11 2023, 12:25 AM
This revision was automatically updated to reflect the committed changes.