This is an archive of the discontinued LLVM Phabricator instance.

flang: break the build on a 32bits system
ClosedPublic

Authored by sylvestre.ledru on Jan 6 2023, 6:32 AM.

Diff Detail

Event Timeline

sylvestre.ledru created this revision.Jan 6 2023, 6:32 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
sylvestre.ledru requested review of this revision.Jan 6 2023, 6:32 AM

Improve the wording

PeteSteinfeld retitled this revision from flang: break the build on a 32bits systeem to flang: break the build on a 32bits system.Jan 6 2023, 7:54 AM
PeteSteinfeld accepted this revision.Jan 6 2023, 8:06 AM

Aside from the message correction nit, all builds and tests correctly and looks good.

Thanks for doing this!

flang/CMakeLists.txt
59

"on on" should read "on"

This revision is now accepted and ready to land.Jan 6 2023, 8:06 AM
This revision was automatically updated to reflect the committed changes.
kkwli0 added a subscriber: kkwli0.Jan 6 2023, 12:07 PM
kkwli0 added inline comments.
flang/CMakeLists.txt
59

A compiler can have a 32-bit mode compile on a 64-bit CPU. In that case, the condition will still be false. I suggest to change "on 32 bit CPUs" to "in 32-bit mode".