This is an archive of the discontinued LLVM Phabricator instance.

Differential D141130

[UpdateTestChecks] Add wasm64 target
ClosedPublic

Authored by luke on Jan 6 2023, 5:58 AM.

Details

Reviewers
dschuff
sunfish
asb
Commits
rGf085d089f9db: [UpdateTestChecks] Add wasm64 target
Summary

wasm32 was already supported, so here I've just reused the same regex. I'm not sure if this is actually correct: I don't know for certain if wasm32 and wasm64 have different output formats, but it seems to work.

Diff Detail

Event Timeline

luke created this revision.Jan 6 2023, 5:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 5:58 AM
Herald added subscribers: luismarques, pmatos, arichardson. · View Herald Transcript
luke requested review of this revision.Jan 6 2023, 5:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 5:58 AM
Herald added subscribers: llvm-commits, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B206096: Diff 486843.Jan 6 2023, 7:34 AM
dschuff accepted this revision.Jan 9 2023, 11:43 AM
This revision is now accepted and ready to land.Jan 9 2023, 11:43 AM
dschuff added a comment.Jan 9 2023, 11:44 AM

I think the format should be the same for wasm64

asb accepted this revision.Jan 10 2023, 1:40 AM
asb added a subscriber: asb.

LGTM!

Closed by commit rGf085d089f9db: [UpdateTestChecks] Add wasm64 target (authored by luke). · Explain WhyJan 10 2023, 2:58 AM
This revision was automatically updated to reflect the committed changes.
luke added a commit: rGf085d089f9db: [UpdateTestChecks] Add wasm64 target.

Revision Contents

PathSize
llvm/
utils/
UpdateTestChecks/
7 lines

Diff 487731

llvm/utils/UpdateTestChecks/asm.py

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 LinesASM_FUNCTION_THUMB_DARWIN_RE = re.compile(
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_ARM_IOS_RE = re.compile( ASM_FUNCTION_ARM_IOS_RE = re.compile(
r'^_(?P<func>[^:]+):\n' r'^_(?P<func>[^:]+):\n'
r'(?P<body>.*?)' r'(?P<body>.*?)'
r'^[ \t]*@[ \t]--[ \t]End[ \t]function', r'^[ \t]*@[ \t]--[ \t]End[ \t]function',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_WASM32_RE = re.compile( ASM_FUNCTION_WASM_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@"?(?P=func)"?\n' r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@"?(?P=func)"?\n'
r'(?P<body>.*?)\n' r'(?P<body>.*?)\n'
r'^\s*(\.Lfunc_end[0-9]+:\n|end_function)', r'^\s*(\.Lfunc_end[0-9]+:\n|end_function)',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_VE_RE = re.compile( ASM_FUNCTION_VE_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n' r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n'
r'(?:\s*\.?L(?P=func)\$local:\n)?' # optional .L<func>$local: due to -fno-semantic-interposition r'(?:\s*\.?L(?P=func)\$local:\n)?' # optional .L<func>$local: due to -fno-semantic-interposition
▲ Show 20 Lines • Show All 224 Lines • ▼ Show 20 Linesdef scrub_asm_systemz(asm, args):
# whitespace in place. # whitespace in place.
asm = common.SCRUB_WHITESPACE_RE.sub(r' ', asm) asm = common.SCRUB_WHITESPACE_RE.sub(r' ', asm)
# Expand the tabs used for indentation. # Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2) asm = string.expandtabs(asm, 2)
# Strip trailing whitespace. # Strip trailing whitespace.
asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm) asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
return asm return asm
def scrub_asm_wasm32(asm, args): def scrub_asm_wasm(asm, args):
# Scrub runs of whitespace out of the assembly, but leave the leading # Scrub runs of whitespace out of the assembly, but leave the leading
# whitespace in place. # whitespace in place.
asm = common.SCRUB_WHITESPACE_RE.sub(r' ', asm) asm = common.SCRUB_WHITESPACE_RE.sub(r' ', asm)
# Expand the tabs used for indentation. # Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2) asm = string.expandtabs(asm, 2)
# Strip trailing whitespace. # Strip trailing whitespace.
asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm) asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
return asm return asm
▲ Show 20 Lines • Show All 79 Lines • ▼ Show 20 Lines target_handlers = {
'ppc32': (scrub_asm_powerpc, ASM_FUNCTION_PPC_RE), 'ppc32': (scrub_asm_powerpc, ASM_FUNCTION_PPC_RE),
'ppc64': (scrub_asm_powerpc, ASM_FUNCTION_PPC_RE), 'ppc64': (scrub_asm_powerpc, ASM_FUNCTION_PPC_RE),
'powerpc': (scrub_asm_powerpc, ASM_FUNCTION_PPC_RE), 'powerpc': (scrub_asm_powerpc, ASM_FUNCTION_PPC_RE),
'riscv32': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE), 'riscv32': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),
'riscv64': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE), 'riscv64': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),
'lanai': (scrub_asm_lanai, ASM_FUNCTION_LANAI_RE), 'lanai': (scrub_asm_lanai, ASM_FUNCTION_LANAI_RE),
'sparc': (scrub_asm_sparc, ASM_FUNCTION_SPARC_RE), 'sparc': (scrub_asm_sparc, ASM_FUNCTION_SPARC_RE),
's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE), 's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE),
'wasm32': (scrub_asm_wasm32, ASM_FUNCTION_WASM32_RE), 'wasm32': (scrub_asm_wasm, ASM_FUNCTION_WASM_RE),
'wasm64': (scrub_asm_wasm, ASM_FUNCTION_WASM_RE),
've': (scrub_asm_ve, ASM_FUNCTION_VE_RE), 've': (scrub_asm_ve, ASM_FUNCTION_VE_RE),
'csky': (scrub_asm_csky, ASM_FUNCTION_CSKY_RE), 'csky': (scrub_asm_csky, ASM_FUNCTION_CSKY_RE),
'nvptx': (scrub_asm_nvptx, ASM_FUNCTION_NVPTX_RE), 'nvptx': (scrub_asm_nvptx, ASM_FUNCTION_NVPTX_RE),
'loongarch32': (scrub_asm_loongarch, ASM_FUNCTION_LOONGARCH_RE), 'loongarch32': (scrub_asm_loongarch, ASM_FUNCTION_LOONGARCH_RE),
'loongarch64': (scrub_asm_loongarch, ASM_FUNCTION_LOONGARCH_RE) 'loongarch64': (scrub_asm_loongarch, ASM_FUNCTION_LOONGARCH_RE)
} }
handler = None handler = None
best_prefix = '' best_prefix = ''
Show All 19 Lines