This is an archive of the discontinued LLVM Phabricator instance.

[mlir] make multi-size tiling use transform parameters
ClosedPublic

Authored by ftynse on Jan 4 2023, 6:13 AM.

Details

Summary

Use the recently introduced transform dialect parameter mechanism to
perform controllable multi-size tiling with sizes computed at the
transformation time rather than at runtime.

This requires to generalize tile and split structured transform
operations to work with any transform dialect handle types, which is
desirable in itself to avoid unchecked overuse of PDL OperationType.

Diff Detail

Event Timeline

ftynse created this revision.Jan 4 2023, 6:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
ftynse requested review of this revision.Jan 4 2023, 6:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
springerm added inline comments.Jan 5 2023, 3:06 AM
mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
23

This almost looks like a transform dialect equivalent of OpFoldResult. If we had Values instead of Operation *. Maybe worth adding as a comment.

25

Should this be TransformParamTypeInterface?

320–323

Result types are missing

334–337

Result types are missing

ftynse updated this revision to Diff 486596.Jan 5 2023, 8:47 AM
ftynse marked 4 inline comments as done.

Address review.

ftynse added inline comments.Jan 6 2023, 4:21 AM
mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
25

No, I want specifically the Transform_ParamType that was checked to be associated with an integer attribute.

ftynse updated this revision to Diff 490202.Jan 18 2023, 9:36 AM

Provide default types in the C++ and Python builders.

shabalin accepted this revision.EditedJan 19 2023, 1:25 AM

LGTM, thanks for adding extra builders to smooth out breaking changes!

This revision is now accepted and ready to land.Jan 19 2023, 1:25 AM
This revision was landed with ongoing or failed builds.Jan 19 2023, 2:19 AM
This revision was automatically updated to reflect the committed changes.