This is an archive of the discontinued LLVM Phabricator instance.

Differential D140671

[lldb] [utils] Fix linking lit-cpuid to LLVM dylib
ClosedPublic

Authored by mgorny on Dec 26 2022, 5:34 AM.

Details

Reviewers
labath
sylvestre.ledru
JDevlieghere
MaskRay
lenary
Commits
rGdfc20708bcdf: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib
Summary

Use LINK_COMPONENTS instead of manual target_link_libraries to link
lit-cpuid to LLVM components. This ensures that dylib is used along
with LLVM_LINK_LLVM_DYLIB rather than linking to component libraries
that may not be installed.

This fixes build failure on Gentoo after a dep on TargetParser component
was added in f09cf34d00625e57dea5317a3ac0412c07292148.

Diff Detail

Event Timeline

mgorny created this revision.Dec 26 2022, 5:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2022, 5:34 AM
Herald added subscribers: StephenFan, delcypher. · View Herald Transcript
mgorny requested review of this revision.Dec 26 2022, 5:34 AM
Harbormaster completed remote builds in B204916: Diff 485297.Dec 26 2022, 5:37 AM
lenary accepted this revision.Dec 26 2022, 9:37 AM
lenary added a subscriber: lenary.

This looks better to me!

This revision is now accepted and ready to land.Dec 26 2022, 9:37 AM
Closed by commit rGdfc20708bcdf: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib (authored by mgorny). · Explain WhyDec 26 2022, 10:03 AM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rGdfc20708bcdf: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib.
Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2022, 10:03 AM
mgorny added a comment.Dec 26 2022, 10:04 AM

Thanks!

Revision Contents

PathSize
lldb/
utils/
lit-cpuid/
5 lines

Diff 485297

lldb/utils/lit-cpuid/CMakeLists.txt

add_lldb_executable(lit-cpuid add_lldb_executable(lit-cpuid
lit-cpuid.cpp lit-cpuid.cpp
LINK_COMPONENTS
Support
TargetParser
) )
target_link_libraries(lit-cpuid PRIVATE LLVMSupport LLVMTargetParser)
set_target_properties(lit-cpuid PROPERTIES FOLDER "lldb utils") set_target_properties(lit-cpuid PROPERTIES FOLDER "lldb utils")