This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Mark global/scratch_load_d16 as D16Buf
AbandonedPublic

Authored by ruiling on Dec 22 2022, 2:35 AM.

Details

Reviewers
foad
arsenm
Summary

They behave the same way as other d16 buffer instructions.

Diff Detail

Event Timeline

ruiling created this revision.Dec 22 2022, 2:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 2:35 AM
ruiling requested review of this revision.Dec 22 2022, 2:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 2:35 AM
arsenm requested changes to this revision.Dec 22 2022, 4:07 AM

This is also missing from the DS instructions

This revision now requires changes to proceed.Dec 22 2022, 4:07 AM
foad added a comment.Dec 22 2022, 4:21 AM

I am a bit surprised that this does not break the only existing use of this flag in SIInstrInfo::pseudoToMCOpcode.

The flag needs a better name if it is going to apply to all _d16/_d16_hi instructions.