Changes:
- Adding test cases for the big-endian arm configuration
- Fixed the bug that the new tests have revealed
Paths
| Differential D140203
[lld][ARM][3/3]Complete Arm BE32 big-endian support and add tests AbandonedPublic Authored by simpal01 on Dec 16 2022, 3:24 AM.
Details
Summary Changes:
Diff Detail Event TimelineM-Plichta added a child revision: D140202: [lld][ARM][2/3]Big Endian support - Word invariant support.Dec 16 2022, 3:25 AM Comment Actions The title implies that this is just adding tests. Can you update the title to include something like Complete Arm BE32 big-endian support and add tests; or move the SyntheticSections change back to Patch [2/3] I'll be on holiday for the next 3 weeks. Happy for someone else to review in my absence.
Comment Actions Tests are included in the same patch as the functional change, not as a separate commit. This may be a difference between llvm-project and GNU as I think lots of large patch series include tests as a separate commit.
M-Plichta retitled this revision from [lld][ARM][3/3]Big Endian support - Adding tests to [lld][ARM][3/3]Complete Arm BE32 big-endian support and add tests. Comment ActionsThanks for the comments. Hopefully this resolves the problems. Although I'm unsure about the use of read32le in SyntheticSections.cpp Comment Actions This revision is now redundant as I have taken all these changes from here to the same patch (https://reviews.llvm.org/D140202) where we are making all the functional changes.
Revision Contents
Diff 483916 lld/ELF/SyntheticSections.cpp
lld/ELF/Thunks.cpp
lld/test/ELF/arm-data-relocs.s
lld/test/ELF/arm-exidx-emit-relocs.s
lld/test/ELF/arm-exidx-relocatable.s
lld/test/ELF/arm-exidx-sentinel-norelocatable.s
lld/test/ELF/arm-header.s
lld/test/ELF/arm-mov-relocs.s
lld/test/ELF/arm-plt-reloc.s
lld/test/ELF/arm-thumb-plt-reloc.s
lld/test/ELF/arm-thunk-arm-thumb-reuse.s
lld/test/ELF/arm-thunk-edgecase.s
lld/test/ELF/arm-thunk-largesection.s
lld/test/ELF/arm-thunk-linkerscript-dotexpr.s
lld/test/ELF/arm-thunk-linkerscript.s
lld/test/ELF/arm-thunk-nosuitable.s
lld/test/ELF/arm-thunk-re-add.s
lld/test/ELF/arm-thunk-reuse.s
lld/test/ELF/arm-thunk-section-too-large.s
lld/test/ELF/arm-thunk-toolargesection.s
lld/test/ELF/arm-v5-reloc-error.s
lld/test/ELF/emulation-arm.s
|
I think this should be two write32s as the table is made up of two 32-bit values