This is an archive of the discontinued LLVM Phabricator instance.

[AA] Remove CFL AA passes
ClosedPublic

Authored by nikic on Dec 9 2022, 3:28 AM.

Details

Summary

The CFL Steens/Anders alias analysis passes are not enabled by default, and to the best of my knowledge have no pathway towards ever being enabled by default. The last significant interest in these passes seems to date back to 2016. Given the little maintenance these have seen in recent times, I also have very little confidence in the correctness of these passes. I don't think we should keep these in-tree.

Diff Detail

Event Timeline

nikic created this revision.Dec 9 2022, 3:28 AM
nikic requested review of this revision.Dec 9 2022, 3:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 3:28 AM

I'm happy with this. It was effectively dead.

reames accepted this revision.Dec 9 2022, 11:28 AM

LGTM, removing dead code is always worthwhile.

This revision is now accepted and ready to land.Dec 9 2022, 11:28 AM

+1 - thanks for the cleanup :)

fhahn accepted this revision.Dec 9 2022, 2:21 PM

LGTM, thanks for the cleanup!

This revision was landed with ongoing or failed builds.Dec 12 2022, 12:34 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 12:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Enna1 added a subscriber: Enna1.Dec 19 2022, 5:31 PM
llvm/test/Analysis/CFLAliasAnalysis/Steensgaard/stratified-attrs-indexing.ll