[XCOFF] handle the toc-data for object file generation.

[Esme]

Summary

The toc-data feature has been supported for assembly file generation. This patch handles the toc-data for object file generation.

[shchenz]

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

2334

Same as below, getExplicitSectionGlobal will not pass external globals.

2382

The caller of this function SectionForGlobal is not allowed to pass external (or available externally) globals., So I don't think we need to care about XTY_ER type symbol here. See:

/// This method computes the appropriate section to emit the specified global
/// variable or function definition. This should not be passed external (or
/// available externally) globals.
MCSection *SectionForGlobal(const GlobalObject *GO, SectionKind Kind,
                            const TargetMachine &TM) const;

We should handle the section for external TD symbols in getSectionForExternalReference() and adjust the order when we create the symbol TargetLoweringObjectFileXCOFF::getTargetSymbol(), i.e., handle external symbol first.

llvm/lib/MC/XCOFFObjectWriter.cpp

465–466

This can be put together with previous XMC_TC/XMC_TE case

633

This must also be wrong now as for TOC direct external symbols, there will be no TOC slot for them, so the FiexedValue must always be 0. For example, for below case:

int a = 20;
extern int c;
extern int b;
int d = 10;

int foo(void)
{
  return a + b + c + d;
}

I get:

00000000 <.foo>:
       0: 38 62 00 00  	addi 3, 2, 0
			00000002:  R_TOC	a
       4: 38 82 ff ac  	addi 4, 2, -84
			00000006:  R_TOC	b
       8: 38 a2 ff ac  	addi 5, 2, -84
			0000000a:  R_TOC	c
       c: 38 c2 00 04  	addi 6, 2, 4
			0000000e:  R_TOC	d

a and d are correct, but b/c are obvious wrong.

[Esme]

Addressed comments except for the FixupValue for external TOC data.

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

2382

Thanks, it makes sense more.

llvm/lib/MC/XCOFFObjectWriter.cpp

633

It seems that the behavior of AIX's as is the same? So I'm a bit confused about this.

[shchenz]

llvm/lib/MC/XCOFFObjectWriter.cpp

633

Hmm, I made a test, with the assembly path, I get:

00000000 <.foo>:
       0: 38 62 00 00  	addi 3, 2, 0
			00000002:  R_TOC	a
       4: 80 63 00 00  	lwz 3, 0(3)
       8: 38 82 00 00  	addi 4, 2, 0 ====> The fixed value is 0 here
			0000000a:  R_TOC	b
       c: 80 84 00 00  	lwz 4, 0(4)
      10: 7c 63 22 14  	add 3, 3, 4
      14: 38 82 00 00  	addi 4, 2, 0 ====> The fixed value is 0 here
			00000016:  R_TOC	c
      18: 80 84 00 00  	lwz 4, 0(4)
      1c: 7c 63 22 14  	add 3, 3, 4
      20: 38 82 00 04  	addi 4, 2, 4
			00000022:  R_TOC	d
      24: 80 84 00 00  	lwz 4, 0(4)
      28: 7c 63 22 14  	add 3, 3, 4
      2c: 4e 80 00 20  	blr

This should be right.

[Esme]

Addressed comments.
Changed the Fixup Value for TOC direct external symbols and added test lines for it in toc-data-const.ll.

[shchenz]

Looks right now. Thanks for adding this support.

llvm/lib/MC/XCOFFObjectWriter.cpp

634

Can we add comments here like: "For non toc-data external symbols, R_TOC type relocation will relocate to data symbols that have XCOFF::XTY_SD type csect. For toc-data external symbols, R_TOC type relocation will relocate to data symbols that have XCOFF_ER type csect. For XCOFF_ER kind symbols, there will be no TOC entry for them, so the FixedValue should always be 0."?

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

TargetLoweringObjectFileXCOFF::getTargetSymbol(const GlobalValue *GV,
   // a declaration, a function descriptor, or a common symbol.
   // If a GV represents a GlobalVariable and -fdata-sections is enabled, we
   // also return a qualname so that a label symbol could be avoided.
   // It is inherently ambiguous when the GO represents the address of a
   // function, as the GO could either represent a function descriptor or a
   // function entry point. We choose to always return a function descriptor
   // here.
   if (const GlobalObject *GO = dyn_cast<GlobalObject>(GV)) {
+    if (GO->isDeclarationForLinker())
+      return cast<MCSectionXCOFF>(getSectionForExternalReference(GO, TM))
+          ->getQualNameSymbol();
+
     if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV))
       if (GVar->hasAttribute("toc-data"))
         return cast<MCSectionXCOFF>(
                    SectionForGlobal(GVar, SectionKind::getData(), TM))
             ->getQualNameSymbol();
 
-    if (GO->isDeclarationForLinker())
-      return cast<MCSectionXCOFF>(getSectionForExternalReference(GO, TM))
-          ->getQualNameSymbol();
-
     SectionKind GOKind = getKindForGlobal(GO, TM);
     if (GOKind.isText())
       return cast<MCSectionXCOFF>(
                  getSectionForFunctionDescriptor(cast<Function>(GO), TM))
           ->getQualNameSymbol();
     if ((TM.getDataSections() && !GO->hasSection()) || GO->hasCommonLinkage() ||
         GOKind.isBSSLocal() || GOKind.isThreadBSSLocal())
       return cast<MCSectionXCOFF>(SectionForGlobal(GO, GOKind, TM))
MCSection *TargetLoweringObjectFileXCOFF::getExplicitSectionGlobal(
 
   // Handle the XCOFF::TD case first, then deal with the rest.
   if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GO))
     if (GVar->hasAttribute("toc-data"))
       return getContext().getXCOFFSection(
           SectionName, Kind,
           XCOFF::CsectProperties(/*MappingClass*/ XCOFF::XMC_TD, XCOFF::XTY_SD),
           /* MultiSymbolsAllowed*/ true);
 
   XCOFF::StorageMappingClass MappingClass;
   if (Kind.isText())
     MappingClass = XCOFF::XMC_PR;
   else if (Kind.isData() || Kind.isReadOnlyWithRel() || Kind.isBSS())
     MappingClass = XCOFF::XMC_RW;
   else if (Kind.isReadOnly())
     MappingClass = XCOFF::XMC_RO;
   else
MCSection *TargetLoweringObjectFileXCOFF::getSectionForExternalReference(
   SmallString<128> Name;
   getNameWithPrefix(Name, GO, TM);
 
   XCOFF::StorageMappingClass SMC =
       isa<Function>(GO) ? XCOFF::XMC_DS : XCOFF::XMC_UA;
   if (GO->isThreadLocal())
     SMC = XCOFF::XMC_UL;
 
+  if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GO))
+    if (GVar->hasAttribute("toc-data"))
+      SMC = XCOFF::XMC_TD;
+
   // Externals go into a csect of type ER.
   return getContext().getXCOFFSection(
       Name, SectionKind::getMetadata(),
       XCOFF::CsectProperties(SMC, XCOFF::XTY_ER));
 }
 
 MCSection *TargetLoweringObjectFileXCOFF::SelectSectionForGlobal(
     const GlobalObject *GO, SectionKind Kind, const TargetMachine &TM) const {
   // Handle the XCOFF::TD case first, then deal with the rest.
   if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GO))
     if (GVar->hasAttribute("toc-data")) {
       SmallString<128> Name;
       getNameWithPrefix(Name, GO, TM);
       return getContext().getXCOFFSection(
           Name, Kind, XCOFF::CsectProperties(XCOFF::XMC_TD, XCOFF::XTY_SD),
           /* MultiSymbolsAllowed*/ true);
     }
 
   // Common symbols go into a csect with matching name which will get mapped
   // into the .bss section.
   // Zero-initialized local TLS symbols go into a csect with matching name which
   // will get mapped into the .tbss section.
   if (Kind.isBSSLocal() || GO->hasCommonLinkage() || Kind.isThreadBSSLocal()) {
     SmallString<128> Name;

llvm/lib/MC/XCOFFObjectWriter.cpp

case XCOFF::XMC_TC0:
     assert(XCOFF::XTY_SD == MCSec->getCSectType() &&
            "Only an initialized csect can contain TOC-base.");
     assert(TOCCsects.empty() &&
            "We should have only one TOC-base, and it should be the first csect "
            "in this CsectGroup.");
     return TOCCsects;
   case XCOFF::XMC_TC:
   case XCOFF::XMC_TE:
+  case XCOFF::XMC_TD:
     assert(XCOFF::XTY_SD == MCSec->getCSectType() &&
            "Only an initialized csect can contain TC entry.");
     assert(!TOCCsects.empty() &&
            "We should at least have a TOC-base in this CsectGroup.");
     return TOCCsects;
-  case XCOFF::XMC_TD:
-    report_fatal_error("toc-data not yet supported when writing object files.");
   default:
     report_fatal_error("Unhandled mapping of csect to section.");
   }
 }
 
 static MCSectionXCOFF *getContainingCsect(const MCSymbolXCOFF *XSym) {
   if (XSym->isDefined())
     return cast<MCSectionXCOFF>(XSym->getFragment()->getParent());
   return XSym->getRepresentedCsect();
void XCOFFObjectWriter::recordRelocation(MCAssembler &Asm,
 
   uint8_t Type;
   uint8_t SignAndSize;
   std::tie(Type, SignAndSize) =
       TargetObjectWriter->getRelocTypeAndSignSize(Target, Fixup, IsPCRel);
 
   const MCSectionXCOFF *SymASec = getContainingCsect(cast<MCSymbolXCOFF>(SymA));
 
-  if (SymASec->isCsect() && SymASec->getMappingClass() == XCOFF::XMC_TD)
-    report_fatal_error("toc-data not yet supported when writing object files.");
-
   assert(SectionMap.find(SymASec) != SectionMap.end() &&
          "Expected containing csect to exist in map.");
 
   const uint32_t Index = getIndex(SymA, SymASec);
   if (Type == XCOFF::RelocationType::R_POS ||
       Type == XCOFF::RelocationType::R_TLS)
     // The FixedValue should be symbol's virtual address in this object file
     // plus any constant value that we might get.
     FixedValue = getVirtualAddress(SymA, SymASec) + Target.getConstant();
   else if (Type == XCOFF::RelocationType::R_TLSM)
     // The FixedValue should always be zero since the region handle is only
     // known at load time.
     FixedValue = 0;
   else if (Type == XCOFF::RelocationType::R_TOC ||
            Type == XCOFF::RelocationType::R_TOCL) {
     // The FixedValue should be the TOC entry offset from the TOC-base plus any
     // constant offset value.
     const int64_t TOCEntryOffset = SectionMap[SymASec]->Address -
                                    TOCCsects.front().Address +
                                    Target.getConstant();
     if (Type == XCOFF::RelocationType::R_TOC && !isInt<16>(TOCEntryOffset))
       report_fatal_error("TOCEntryOffset overflows in small code model mode");
 
     FixedValue = TOCEntryOffset;
   }
 
   assert((Fixup.getOffset() <=
           MaxRawDataSize - Layout.getFragmentOffset(Fragment)) &&
          "Fragment offset + fixup offset is overflowed.");
   uint32_t FixupOffsetInCsect =
       Layout.getFragmentOffset(Fragment) + Fixup.getOffset();
 
   XCOFFRelocation Reloc = {Index, FixupOffsetInCsect, SignAndSize, Type};

llvm/test/CodeGen/PowerPC/basic-toc-data-def.ll

 ; RUN: llc -mtriple powerpc-ibm-aix-xcoff  -verify-machineinstrs < %s | FileCheck %s
-; RUN: not --crash llc -filetype=obj -mtriple powerpc-ibm-aix-xcoff  \
-; RUN:                 -verify-machineinstrs < %s 2>&1 | \
-; RUN:   FileCheck %s --check-prefix=OBJ
-
 ; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s | FileCheck %s
-; RUN: not --crash llc -filetype=obj -mtriple powerpc64-ibm-aix-xcoff  \
-; RUN:                 -verify-machineinstrs < %s 2>&1 | \
-; RUN:   FileCheck %s --check-prefix=OBJ
+
+; RUN: llc -filetype=obj -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s -o %t32.o
+; RUN: llvm-readobj %t32.o --syms | FileCheck %s --check-prefix=OBJ32
+; RUN: llc -filetype=obj -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s -o %t64.o
+; RUN: llvm-readobj %t64.o --syms | FileCheck %s --check-prefix=OBJ64
 
 @i = global i32 55, align 4 #0
 
 attributes #0 = { "toc-data" }
+
 ; CHECK:            .toc
 ; CHECK-NEXT:       .csect i[TD],2
 ; CHECK-NEXT:       .globl i[TD]
 ; CHECK-NEXT:       .align 2
 ; CHECK-NEXT:       .vbyte 4, 55
 
-; OBJ: LLVM ERROR:  toc-data not yet supported when writing object files.
+; OBJ32:      Symbol {
+; OBJ32:        Index: 3
+; OBJ32-NEXT:   Name: TOC
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ32-NEXT:   Section: .data
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_HIDEXT (0x6B)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 4
+; OBJ32-NEXT:     SectionLen: 0
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 2
+; OBJ32-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TC0 (0xF)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+; OBJ32-NEXT: Symbol {
+; OBJ32-NEXT:   Index: 5
+; OBJ32-NEXT:   Name: i
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ32-NEXT:   Section: .data
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 6
+; OBJ32-NEXT:     SectionLen: 4
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 2
+; OBJ32-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+
+; OBJ64:      Symbol {
+; OBJ64:        Index: 3
+; OBJ64-NEXT:   Name: TOC
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ64-NEXT:   Section: .data
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_HIDEXT (0x6B)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 4
+; OBJ64-NEXT:     SectionLen: 0
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 2
+; OBJ64-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TC0 (0xF)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }
+; OBJ64-NEXT: Symbol {
+; OBJ64-NEXT:   Index: 5
+; OBJ64-NEXT:   Name: i
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ64-NEXT:   Section: .data
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 6
+; OBJ64-NEXT:     SectionLen: 4
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 2
+; OBJ64-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }

llvm/test/CodeGen/PowerPC/basic-toc-data-extern.ll

 ; RUN: llc -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s | FileCheck %s
-; RUN: not --crash llc -filetype=obj -mtriple powerpc-ibm-aix-xcoff  \
-; RUN:                 -verify-machineinstrs < %s 2>&1 | \
-; RUN:   FileCheck %s --check-prefix=OBJ
-
 ; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s | FileCheck %s
-; RUN: not --crash llc -filetype=obj -mtriple powerpc64-ibm-aix-xcoff  \
-; RUN:                 -verify-machineinstrs < %s 2>&1 | \
-; RUN:   FileCheck %s --check-prefix=OBJ
+
+; RUN: llc -filetype=obj -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s -o %t32.o
+; RUN: llvm-readobj %t32.o --syms --relocs | FileCheck %s --check-prefix=OBJ32
+; RUN: llc -filetype=obj -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s -o %t64.o
+; RUN: llvm-readobj %t64.o --syms --relocs | FileCheck %s --check-prefix=OBJ64
 
 @i = external global i32, align 4  #0
 
 ; Function Attrs: noinline nounwind optnone
 define ptr @get() {
   entry:
     ret ptr @i
 }
 
+attributes #0 = { "toc-data" }
+
 ; CHECK:        la 3, i[TD](2)
 ; CHECK:        .toc
 ; CHECK-NEXT:   .extern i[TD]
 
-; OBJ: LLVM ERROR:  toc-data not yet supported when writing object files.
-
-attributes #0 = { "toc-data" }
+; OBJ32:      Relocations [
+; OBJ32-NEXT:   Section (index: 1) .text {
+; OBJ32-NEXT:     0x2 R_TOC i(1) 0xF
+; OBJ32-NEXT:   }
+; OBJ32-NEXT:   Section (index: 2) .data {
+; OBJ32-NEXT:     0x20 R_POS .get(5) 0x1F
+; OBJ32-NEXT:     0x24 R_POS TOC(9) 0x1F
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: ]
+
+; OBJ32:      Symbol {
+; OBJ32:        Index: 1
+; OBJ32-NEXT:   Name: i
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ32-NEXT:   Section: N_UNDEF
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 2
+; OBJ32-NEXT:     SectionLen: 0
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 0
+; OBJ32-NEXT:     SymbolType: XTY_ER (0x0)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+; OBJ32:      Symbol {
+; OBJ32:        Index: 9
+; OBJ32-NEXT:   Name: TOC
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x2C
+; OBJ32-NEXT:   Section: .data
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_HIDEXT (0x6B)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 10
+; OBJ32-NEXT:     SectionLen: 0
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 2
+; OBJ32-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TC0 (0xF)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+
+; OBJ64:      Relocations [
+; OBJ64-NEXT:   Section (index: 1) .text {
+; OBJ64-NEXT:     0x2 R_TOC i(1) 0xF
+; OBJ64-NEXT:   }
+; OBJ64-NEXT:   Section (index: 2) .data {
+; OBJ64-NEXT:     0x20 R_POS .get(5) 0x3F
+; OBJ64-NEXT:     0x28 R_POS TOC(9) 0x3F
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: ]
+
+; OBJ64:      Symbol {
+; OBJ64:        Index: 1
+; OBJ64-NEXT:   Name: i
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ64-NEXT:   Section: N_UNDEF
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 2
+; OBJ64-NEXT:     SectionLen: 0
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 0
+; OBJ64-NEXT:     SymbolType: XTY_ER (0x0)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }
+; OBJ64:      Symbol {
+; OBJ64:        Index: 9
+; OBJ64-NEXT:   Name: TOC
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x38
+; OBJ64-NEXT:   Section: .data
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_HIDEXT (0x6B)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 10
+; OBJ64-NEXT:     SectionLen: 0
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 2
+; OBJ64-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TC0 (0xF)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }

llvm/test/CodeGen/PowerPC/toc-data-const.ll

 ; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s | FileCheck %s --check-prefix CHECK
 ; RUN: llc -mtriple powerpc64-ibm-aix-xcoff < %s | FileCheck %s --check-prefix CHECK
 
+; RUN: llc -filetype=obj -mtriple powerpc-ibm-aix-xcoff -verify-machineinstrs < %s -o %t32.o
+; RUN: llvm-readobj %t32.o --syms --relocs | FileCheck %s --check-prefix=OBJ32
+; RUN: llc -filetype=obj -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s -o %t64.o
+; RUN: llvm-readobj %t64.o --syms --relocs | FileCheck %s --check-prefix=OBJ64
+
 @i1 = external constant i32 #0
 @i2 = constant ptr @i1 #0
 
 define i32 @read() {
   %1  = load i32, ptr @i1, align 4
   ret i32 %1
 }
 
 define ptr @retptr() {
   ret ptr @i2
 }
 
+attributes #0 = { "toc-data" }
+
 ; CHECK:       .read:
 ; CHECK:        la 3, i1[TD](2)
 
 ; CHECK:       .retptr:
 ; CHECK:        la 3, i2[TD](2)
 
 ; CHECK-DAG:   .toc
 ; CHECK:         .extern i1[TD]
 ; CHECK:         .csect i2[TD]
 
-attributes #0 = { "toc-data" }
+; OBJ32:      Relocations [
+; OBJ32-NEXT:   Section (index: 1) .text {
+; OBJ32-NEXT:     0x2 R_TOC i1(1) 0xF
+; OBJ32-NEXT:     0x26 R_TOC i2(15) 0xF
+; OBJ32-NEXT:   }
+; OBJ32-NEXT:   Section (index: 2) .data {
+; OBJ32-NEXT:     0x44 R_POS .read(5) 0x1F
+; OBJ32-NEXT:     0x48 R_POS TOC(13) 0x1F
+; OBJ32-NEXT:     0x50 R_POS .retptr(7) 0x1F
+; OBJ32-NEXT:     0x54 R_POS TOC(13) 0x1F
+; OBJ32-NEXT:     0x5C R_POS i1(1) 0x1F
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: ]
+
+; OBJ32:      Symbol {
+; OBJ32:        Index: 1
+; OBJ32-NEXT:   Name: i1
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ32-NEXT:   Section: N_UNDEF
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 2
+; OBJ32-NEXT:     SectionLen: 0
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 0
+; OBJ32-NEXT:     SymbolType: XTY_ER (0x0)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+; OBJ32:      Symbol {
+; OBJ32:        Index: 13
+; OBJ32-NEXT:   Name: TOC
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x5C
+; OBJ32-NEXT:   Section: .data
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_HIDEXT (0x6B)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 14
+; OBJ32-NEXT:     SectionLen: 0
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 2
+; OBJ32-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TC0 (0xF)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+; OBJ32:      Symbol {
+; OBJ32:        Index: 15
+; OBJ32-NEXT:   Name: i2
+; OBJ32-NEXT:   Value (RelocatableAddress): 0x5C
+; OBJ32-NEXT:   Section: .data
+; OBJ32-NEXT:   Type: 0x0
+; OBJ32-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ32-NEXT:   NumberOfAuxEntries: 1
+; OBJ32-NEXT:   CSECT Auxiliary Entry {
+; OBJ32-NEXT:     Index: 16
+; OBJ32-NEXT:     SectionLen: 4
+; OBJ32-NEXT:     ParameterHashIndex: 0x0
+; OBJ32-NEXT:     TypeChkSectNum: 0x0
+; OBJ32-NEXT:     SymbolAlignmentLog2: 2
+; OBJ32-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ32-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ32-NEXT:     StabInfoIndex: 0x0
+; OBJ32-NEXT:     StabSectNum: 0x0
+; OBJ32-NEXT:   }
+; OBJ32-NEXT: }
+
+; OBJ64:      Relocations [
+; OBJ64-NEXT:   Section (index: 1) .text {
+; OBJ64-NEXT:     0x2 R_TOC i1(1) 0xF
+; OBJ64-NEXT:     0x26 R_TOC i2(15) 0xF
+; OBJ64-NEXT:   }
+; OBJ64-NEXT:   Section (index: 2) .data {
+; OBJ64-NEXT:     0x48 R_POS .read(5) 0x3F
+; OBJ64-NEXT:     0x50 R_POS TOC(13) 0x3F
+; OBJ64-NEXT:     0x60 R_POS .retptr(7) 0x3F
+; OBJ64-NEXT:     0x68 R_POS TOC(13) 0x3F
+; OBJ64-NEXT:     0x78 R_POS i1(1) 0x3F
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: ]
+
+; OBJ64:      Symbol {
+; OBJ64:        Index: 1
+; OBJ64-NEXT:   Name: i1
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x0
+; OBJ64-NEXT:   Section: N_UNDEF
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 2
+; OBJ64-NEXT:     SectionLen: 0
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 0
+; OBJ64-NEXT:     SymbolType: XTY_ER (0x0)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }
+; OBJ64:      Symbol {
+; OBJ64:        Index: 13
+; OBJ64-NEXT:   Name: TOC
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x78
+; OBJ64-NEXT:   Section: .data
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_HIDEXT (0x6B)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 14
+; OBJ64-NEXT:     SectionLen: 0
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 2
+; OBJ64-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TC0 (0xF)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }
+; OBJ64:      Symbol {
+; OBJ64:        Index: 15
+; OBJ64-NEXT:   Name: i2
+; OBJ64-NEXT:   Value (RelocatableAddress): 0x78
+; OBJ64-NEXT:   Section: .data
+; OBJ64-NEXT:   Type: 0x0
+; OBJ64-NEXT:   StorageClass: C_EXT (0x2)
+; OBJ64-NEXT:   NumberOfAuxEntries: 1
+; OBJ64-NEXT:   CSECT Auxiliary Entry {
+; OBJ64-NEXT:     Index: 16
+; OBJ64-NEXT:     SectionLen: 8
+; OBJ64-NEXT:     ParameterHashIndex: 0x0
+; OBJ64-NEXT:     TypeChkSectNum: 0x0
+; OBJ64-NEXT:     SymbolAlignmentLog2: 3
+; OBJ64-NEXT:     SymbolType: XTY_SD (0x1)
+; OBJ64-NEXT:     StorageMappingClass: XMC_TD (0x10)
+; OBJ64-NEXT:     Auxiliary Type: AUX_CSECT (0xFB)
+; OBJ64-NEXT:   }
+; OBJ64-NEXT: }