[lldb][Module][NFC] Add ModuleList::AnyOf

[Michael137]

This comment was removed by Michael137.

[aprantl]

This is definitely useful — I just have one question: Isn't ForEach a special case of AnyOf? Could we implement on in terms of the other?

lldb/include/lldb/Core/ModuleList.h

480

Why not std::function<bool(const lldb::Module &)> ?

[Michael137]

lldb/include/lldb/Core/ModuleList.h

480

Unfortunately a lot of APIs of Module are non-const since they rely on updating internal state :(

[Michael137]

In D139083#3964612, @aprantl wrote:

This is definitely useful — I just have one question: Isn't ForEach a special case of AnyOf? Could we implement on in terms of the other?

Yup it is. But it looked a bit too clever:

bool ret = false;
ForEach([&](auto const& module) {
    if (callback(module)) {
        ret = true;
        return false;
    }

    return true;
}

return ret;

Just iterating over m_modules seemed cleaner.

lldb/include/lldb/Core/ModuleList.h

480

Re. why shared_ptr, that's because I just waned to align it with ForEach. I suppose if we're starting fresh we could just pass the reference. It would have to be mutable though

[Michael137]

• Reference insstead of shared_ptr

[aprantl]

lldb/source/Core/ModuleList.cpp

1079

module

lldb/include/lldb/Core/ModuleList.h

public:
   /// If 'callback' returns false, iteration terminates.
   /// The 'module_sp' passed to 'callback' is guaranteed to
   /// be non-null.
   ///
   /// This function is thread-safe.
   void ForEach(std::function<bool(const lldb::ModuleSP &module_sp)> const
                    &callback) const;
 
+  /// Returns true if 'callback' returns true for one of the modules
+  /// in this ModuleList.
+  ///
+  /// This function is thread-safe.
+  bool AnyOf(
+      std::function<bool(lldb_private::Module &module)> const &callback) const;
+
 protected:
   // Class typedefs.
   typedef std::vector<lldb::ModuleSP>
       collection; ///< The module collection type.
 
   void AppendImpl(const lldb::ModuleSP &module_sp, bool use_notifier = true);
 
   bool RemoveImpl(const lldb::ModuleSP &module_sp, bool use_notifier = true);

lldb/source/Core/ModuleList.cpp

void ModuleList::ForEach(
   std::lock_guard<std::recursive_mutex> guard(m_modules_mutex);
   for (const auto &module_sp : m_modules) {
     assert(module_sp != nullptr);
     // If the callback returns false, then stop iterating and break out
     if (!callback(module_sp))
       break;
   }
 }
+
+bool ModuleList::AnyOf(
+    std::function<bool(lldb_private::Module &module_sp)> const &callback)
+    const {
+  std::lock_guard<std::recursive_mutex> guard(m_modules_mutex);
+  for (const auto &module_sp : m_modules) {
+    assert(module_sp != nullptr);
+    if (callback(*module_sp))
+      return true;
+  }
+
+  return false;
+}