This is an archive of the discontinued LLVM Phabricator instance.

Differential D138818

[openmp] [test] Use stdint.h instead of manual code defining kmp_int*. NFC.
ClosedPublic

Authored by mstorsjo on Nov 28 2022, 7:09 AM.

Details

Reviewers
AndreyChurbanov
JonChesterfield
natgla
jdoerfert
Meinersbur
jlpeyton
Commits
rG624e9e131827: [openmp] [test] Use stdint.h instead of manual code defining kmp_int*. NFC.

Diff Detail

Event Timeline

mstorsjo created this revision.Nov 28 2022, 7:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 7:09 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
mstorsjo requested review of this revision.Nov 28 2022, 7:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 7:09 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
mstorsjo added a parent revision: D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info.Nov 28 2022, 7:09 AM
Harbormaster completed remote builds in B199760: Diff 478235.Nov 28 2022, 7:12 AM
natgla accepted this revision.Nov 28 2022, 9:40 AM
This revision is now accepted and ready to land.Nov 28 2022, 9:40 AM
JonChesterfield accepted this revision.Nov 28 2022, 3:48 PM
Closed by commit rG624e9e131827: [openmp] [test] Use stdint.h instead of manual code defining kmp_int*. NFC. (authored by mstorsjo). · Explain WhyNov 29 2022, 1:17 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG624e9e131827: [openmp] [test] Use stdint.h instead of manual code defining kmp_int*. NFC..

Revision Contents

PathSize
openmp/
runtime/
test/
tasking/
11 lines
11 lines

Diff 478705

openmp/runtime/test/tasking/bug_nested_proxy_task.c

// RUN: %libomp-compile-and-run // RUN: %libomp-compile-and-run
// The runtime currently does not get dependency information from GCC. // The runtime currently does not get dependency information from GCC.
// UNSUPPORTED: gcc // UNSUPPORTED: gcc
// Very flaky on openmp-clang-x86_64-linux-debian. // Very flaky on openmp-clang-x86_64-linux-debian.
// https://bugs.llvm.org/show_bug.cgi?id=45397 // https://bugs.llvm.org/show_bug.cgi?id=45397
// UNSUPPORTED: linux // UNSUPPORTED: linux
#include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <omp.h> #include <omp.h>
#include "omp_testsuite.h" #include "omp_testsuite.h"
#include "omp_my_sleep.h" #include "omp_my_sleep.h"
/* /*
With task dependencies one can generate proxy tasks from an explicit task With task dependencies one can generate proxy tasks from an explicit task
being executed by a serial task team. The OpenMP runtime library didn't being executed by a serial task team. The OpenMP runtime library didn't
expect that and tries to free the explicit task that is the parent of the expect that and tries to free the explicit task that is the parent of the
proxy task still working in background. It therefore has incomplete children proxy task still working in background. It therefore has incomplete children
which triggers a debugging assertion. which triggers a debugging assertion.
*/ */
// Compiler-generated code (emulation) // Compiler-generated code (emulation)
#ifdef _WIN64 typedef intptr_t kmp_intptr_t;
typedef long long kmp_intptr_t; typedef int32_t kmp_int32;
#else typedef uint8_t kmp_uint8;
typedef long kmp_intptr_t;
#endif
typedef int kmp_int32;
typedef unsigned char kmp_uint8;
typedef char bool; typedef char bool;
// These structs need to match the implementation within libomp, in kmp.h. // These structs need to match the implementation within libomp, in kmp.h.
typedef struct ident { typedef struct ident {
kmp_int32 reserved_1; /**< might be used in Fortran; see above */ kmp_int32 reserved_1; /**< might be used in Fortran; see above */
kmp_int32 flags; /**< also f.flags; KMP_IDENT_xxx flags; KMP_IDENT_KMPC identifies this union member */ kmp_int32 flags; /**< also f.flags; KMP_IDENT_xxx flags; KMP_IDENT_KMPC identifies this union member */
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

openmp/runtime/test/tasking/bug_proxy_task_dep_waiting.c

// RUN: %libomp-compile-and-run // RUN: %libomp-compile-and-run
// The runtime currently does not get dependency information from GCC. // The runtime currently does not get dependency information from GCC.
// UNSUPPORTED: gcc // UNSUPPORTED: gcc
// Very flaky on openmp-clang-x86_64-linux-debian. // Very flaky on openmp-clang-x86_64-linux-debian.
// https://bugs.llvm.org/show_bug.cgi?id=45397 // https://bugs.llvm.org/show_bug.cgi?id=45397
// UNSUPPORTED: linux // UNSUPPORTED: linux
#include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <omp.h> #include <omp.h>
#include "omp_testsuite.h" #include "omp_testsuite.h"
#include "omp_my_sleep.h" #include "omp_my_sleep.h"
/* /*
An explicit task can have a dependency on a target task. If it is not An explicit task can have a dependency on a target task. If it is not
directly satisfied, the runtime should not wait but resume execution. directly satisfied, the runtime should not wait but resume execution.
*/ */
// Compiler-generated code (emulation) // Compiler-generated code (emulation)
#ifdef _WIN64 typedef intptr_t kmp_intptr_t;
typedef long long kmp_intptr_t; typedef int32_t kmp_int32;
#else typedef uint8_t kmp_uint8;
typedef long kmp_intptr_t;
#endif
typedef int kmp_int32;
typedef unsigned char kmp_uint8;
typedef char bool; typedef char bool;
// These structs need to match the implementation within libomp, in kmp.h. // These structs need to match the implementation within libomp, in kmp.h.
typedef struct ident { typedef struct ident {
kmp_int32 reserved_1; /**< might be used in Fortran; see above */ kmp_int32 reserved_1; /**< might be used in Fortran; see above */
kmp_int32 flags; /**< also f.flags; KMP_IDENT_xxx flags; KMP_IDENT_KMPC identifies this union member */ kmp_int32 flags; /**< also f.flags; KMP_IDENT_xxx flags; KMP_IDENT_KMPC identifies this union member */
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines