Page MenuHomePhabricator

[Flang][Test] Add support to change the default target triple for tests
AcceptedPublic

Authored by mnadeem on Tue, Nov 22, 4:16 PM.

Details

Summary

In this patch I added support to change the default target triple used by flang tests using the cmake variable: -DFLANG_TEST_TARGET_TRIPLE="xxx".

The motivation for this is that we build our full toolchain for multiple targets e.g. aarch64, arm32 etc but we set arm32 as the default triple and we want to enable flang build in our CI. Since arm32 has no flang support, a bunch of tests are failing. To enable flang in our CI, changing the flang test triple using -DFLANG_TEST_TARGET_TRIPLE="aarch64-linux-gnu" works in the interim.

Please let me know if something like this has any value to the community.

Diff Detail

Event Timeline

mnadeem created this revision.Tue, Nov 22, 4:16 PM
Herald added a project: Restricted Project. · View Herald Transcript
mnadeem requested review of this revision.Tue, Nov 22, 4:16 PM
DavidTruby accepted this revision.EditedThu, Nov 24, 6:20 AM
DavidTruby added a subscriber: DavidTruby.

LGTM, if this supports getting more flang build bots up then I do think it has value
Thanks!

This revision is now accepted and ready to land.Thu, Nov 24, 6:20 AM