Page MenuHomePhabricator
Differential D138437

[mlir][llvm] Make additional int debug attribute parameters optional.
ClosedPublic
Actions

Authored by gysit on Nov 21 2022, 7:42 AM.

Details

Reviewers
ftynse
nicolasvasilache
dcaballe
rriddle
Commits
rG36fa80b04656: [mlir][llvm] Make additional int debug attribute parameters optional.
Summary

The revision makes additional integer debug info parameters such as
line or column numbers optional (e.g. the line and column numbers 0 are
elided when printing, which is in line with the LLVM implementation).

Depends on D138405

Diff Detail

Event Timeline

gysit created this revision.Nov 21 2022, 7:42 AM
Herald added a reviewer: ftynse. · View Herald TranscriptNov 21 2022, 7:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
gysit requested review of this revision.Nov 21 2022, 7:42 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 21 2022, 7:42 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B198792: Diff 476900.Nov 21 2022, 4:21 PM
gysit added a reviewer: rriddle.Nov 28 2022, 11:58 PM
rriddle accepted this revision.Nov 29 2022, 12:03 AM
This revision is now accepted and ready to land.Nov 29 2022, 12:03 AM
Closed by commit rG36fa80b04656: [mlir][llvm] Make additional int debug attribute parameters optional. (authored by gysit). · Explain WhyNov 29 2022, 4:06 AM
This revision was automatically updated to reflect the committed changes.
gysit added a commit: rG36fa80b04656: [mlir][llvm] Make additional int debug attribute parameters optional..

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
20 lines
test/
Dialect/
LLVMIR/
36 lines
Target/
LLVMIR/
Import/
30 lines
31 lines

Diff 476900

View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

Loading...
View Options

mlir/test/Dialect/LLVMIR/debuginfo.mlir

Loading...
View Options

mlir/test/Target/LLVMIR/Import/debug-info.ll

Loading...
View Options

mlir/test/Target/LLVMIR/llvmir-debug.mlir

Loading...