This is an archive of the discontinued LLVM Phabricator instance.

Differential D138433

Allow setting LLVM_EXPERIMENTAL_TARGETS_TO_BUILD to "all"
ClosedPublic

Authored by arichardson on Nov 21 2022, 6:46 AM.

Details

Reviewers
beanz
Commits
rG1908820d6de5: Allow setting LLVM_EXPERIMENTAL_TARGETS_TO_BUILD to "all"
Summary

When set to "all" we will now build all experimental targets. This matches
the behaviour for LLVM_TARGETS_TO_BUILD.

Diff Detail

Event Timeline

arichardson created this revision.Nov 21 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 6:46 AM
arichardson requested review of this revision.Nov 21 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 6:46 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B198783: Diff 476888.Nov 21 2022, 4:06 PM
arichardson added a comment.Jun 27 2023, 9:20 AM

ping

beanz accepted this revision.Jun 27 2023, 11:19 AM

LGTM

This revision is now accepted and ready to land.Jun 27 2023, 11:19 AM
Closed by commit rG1908820d6de5: Allow setting LLVM_EXPERIMENTAL_TARGETS_TO_BUILD to "all" (authored by arichardson). · Explain WhyJun 27 2023, 4:54 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG1908820d6de5: Allow setting LLVM_EXPERIMENTAL_TARGETS_TO_BUILD to "all".
foad added a subscriber: foad.Jul 4 2023, 1:45 AM

@arichardson thank you for doing this!

barannikov88 added a subscriber: barannikov88.Jul 4 2023, 12:48 PM

Thanks, always wanted to do this, but never had time.

Revision Contents

PathSize
llvm/
14 lines

Diff 476888

llvm/CMakeLists.txt

Show First 20 Lines • Show All 423 Lines • ▼ Show 20 Linesset(LLVM_ALL_TARGETS
Sparc Sparc
SystemZ SystemZ
VE VE
WebAssembly WebAssembly
X86 X86
XCore XCore
) )
set(LLVM_ALL_EXPERIMENTAL_TARGETS
ARC
CSKY
DirectX
LoongArch
M68k
SPIRV
)
# List of targets with JIT support: # List of targets with JIT support:
set(LLVM_TARGETS_WITH_JIT X86 PowerPC AArch64 ARM Mips SystemZ) set(LLVM_TARGETS_WITH_JIT X86 PowerPC AArch64 ARM Mips SystemZ)
set(LLVM_TARGETS_TO_BUILD "all" set(LLVM_TARGETS_TO_BUILD "all"
CACHE STRING "Semicolon-separated list of targets to build, or \"all\".") CACHE STRING "Semicolon-separated list of targets to build, or \"all\".")
set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD "" set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD ""
CACHE STRING "Semicolon-separated list of experimental targets to build.") CACHE STRING "Semicolon-separated list of experimental targets to build.")
▲ Show 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}") set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
if( LLVM_TARGETS_TO_BUILD STREQUAL "all" ) if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} ) set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
endif() endif()
if(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD STREQUAL "all" )
set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD ${LLVM_ALL_EXPERIMENTAL_TARGETS})
endif()
set(LLVM_TARGETS_TO_BUILD set(LLVM_TARGETS_TO_BUILD
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
${LLVM_EXPERIMENTAL_TARGETS_TO_BUILD}) ${LLVM_EXPERIMENTAL_TARGETS_TO_BUILD})
list(REMOVE_DUPLICATES LLVM_TARGETS_TO_BUILD) list(REMOVE_DUPLICATES LLVM_TARGETS_TO_BUILD)
option(LLVM_ENABLE_PIC "Build Position-Independent Code" ON) option(LLVM_ENABLE_PIC "Build Position-Independent Code" ON)
option(LLVM_ENABLE_MODULES "Compile with C++ modules enabled." OFF) option(LLVM_ENABLE_MODULES "Compile with C++ modules enabled." OFF)
if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
▲ Show 20 Lines • Show All 837 Lines • Show Last 20 Lines