This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Drop and upgrade llvm.amdgcn.atomic.inc/dec to atomicrmw
ClosedPublic

Authored by arsenm on Nov 6 2022, 9:13 PM.

Details

Reviewers
vangthao
pravinjagtap
Pierre-vh
cdevadas
rampitec
Joe_Nash
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

arsenm created this revision.Nov 6 2022, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 9:13 PM
arsenm requested review of this revision.Nov 6 2022, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 6 2022, 9:13 PM
Herald added a subscriber: wdng. · View Herald Transcript
cdevadas added inline comments.Jun 21 2023, 12:48 PM
llvm/test/CodeGen/AMDGPU/GlobalISel/atomicrmw_uinc_wrap.ll
70

There are additional waitcnt instructions in most of the lit pattern changes. Were they regressions earlier?

arsenm added inline comments.Jun 21 2023, 12:51 PM
llvm/test/CodeGen/AMDGPU/GlobalISel/atomicrmw_uinc_wrap.ll
70

Without an ordering passed through to the memory legalizer, these weren’t actually treated as atomics. They were not properly legalized before

This revision is now accepted and ready to land.Jun 21 2023, 12:56 PM
llvm/test/Bitcode/amdgcn-atomic.ll