This is an archive of the discontinued LLVM Phabricator instance.

[utils] Remove ancient scripts using llvm-config --src-root
ClosedPublic

Authored by MaskRay on Oct 28 2022, 11:41 AM.

Details

Summary

The last effective changes for the 4 scripts were more than 10 years ago.
They do grep and lines of code counting which have mature modern replacements
(rg, tokei, etc).

Diff Detail

Event Timeline

MaskRay created this revision.Oct 28 2022, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2022, 11:41 AM
MaskRay requested review of this revision.Oct 28 2022, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2022, 11:41 AM

Well, I'm not opposed to seeing them go but let's try to see if we can contact their authors first.

Alternatively to removing them, I suppose we could replace the llvm-config call with computing the path relatively to $0.

I have no objection to removing these!

mgorny accepted this revision.Oct 28 2022, 1:10 PM
This revision is now accepted and ready to land.Oct 28 2022, 1:10 PM
llvm/utils/getsrcs.sh