This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix asan issue in Vectorization.cpp of Linalg.
ClosedPublic

Authored by pifon2a on Oct 27 2022, 9:02 AM.

Diff Detail

Event Timeline

pifon2a created this revision.Oct 27 2022, 9:02 AM
Herald added a project: Restricted Project. · View Herald Transcript
pifon2a requested review of this revision.Oct 27 2022, 9:02 AM
springerm accepted this revision.Oct 27 2022, 9:12 AM
This revision is now accepted and ready to land.Oct 27 2022, 9:12 AM
nicolasvasilache accepted this revision.Oct 27 2022, 9:12 AM
This revision was landed with ongoing or failed builds.Oct 27 2022, 9:13 AM
This revision was automatically updated to reflect the committed changes.
dcaballe added inline comments.Oct 27 2022, 11:43 AM
mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
531

I'm curious... What is asan complaining about here?

pifon2a added inline comments.Oct 27 2022, 11:49 AM
mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
531

For linalg.map there is no block argument that corresponds to the init/output and the old code was still trying to call getArgument() with the Idx which is out-of-bounds.

Thanks for clarifying, Alex!