This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Remove `-Bsymbolic` flag for device linking in the GNU toolchain
ClosedPublic

Authored by jhuber6 on Oct 20 2022, 8:44 AM.

Details

Summary

Previously, OpenMP linking would be done explicitly in a linker stage.
For x86_64 offloading this would just use the host linker, which could
be the bfd linker. This linker had problems linking relocations
against variables with protected visibility so we force -Bsymbolic
when linking. After the deprecation of the old offloading driver this
code is no longer used and can be removed.

Diff Detail

Event Timeline

jhuber6 created this revision.Oct 20 2022, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 8:44 AM
jhuber6 requested review of this revision.Oct 20 2022, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2022, 8:44 AM
This revision is now accepted and ready to land.Oct 20 2022, 9:03 AM