[llvm-debuginfo-analyzer] (04/09) - Locations and ranges - Test case (AddressSanitizer: leaked in allocations)

[CarlosAlbertoEnciso]

Summary

The test case 'LocationCoverage' caused a failure in:

https://lab.llvm.org/buildbot/#/builders/5/builds/28385
https://lab.llvm.org/buildbot/#/builders/168/builds/9585
SUMMARY: AddressSanitizer: 176 byte(s) leaked in 2 allocation(s).

The logical debug locations LocationThree and LocationFour
are not added to any logical scope.

The test case is checking the logical symbol coverage and
it does not use those 2 debug locations.

[probinson]

LGTM. It looks like those location entries aren't adding any coverage so removing them is fine.

[CarlosAlbertoEnciso]

@probinson Thanks for your valuable review.

llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp

class ReaderTestCoverage : public ReaderTest {
   LVLine *LineThree = nullptr;
   LVLine *LineFour = nullptr;
   LVLine *LineFive = nullptr;
   LVLine *LineSix = nullptr;
 
   // Locations.
   LVLocation *LocationOne = nullptr;
   LVLocation *LocationTwo = nullptr;
-  LVLocation *LocationThree = nullptr;
-  LVLocation *LocationFour = nullptr;
   LVLocation *LocationFive = nullptr;
   LVLocation *LocationSix = nullptr;
 
 public:
   ReaderTestCoverage(ScopedPrinter &W) : ReaderTest(W) {}
 
   void createElements();
   void addElements();
void ReaderTestCoverage::createElements() {
   LineThree = create<LVLine>();
   LineFour = create<LVLine>();
   LineFive = create<LVLine>();
   LineSix = create<LVLine>();
 
   // Create the logical locations.
   LocationOne = create<LVLocation>();
   LocationTwo = create<LVLocation>();
-  LocationThree = create<LVLocation>();
-  LocationFour = create<LVLocation>();
   LocationFive = create<LVLocation>();
   LocationSix = create<LVLocation>();
 }
 
 // Create the logical view adding the created logical elements.
 void ReaderTestCoverage::addElements() {
   setCompileUnit(CompileUnit);
 
void ReaderTestCoverage::initElements() {
   set(LocationOne, LineOne, LineOne, 0x5000, 0x5199);
   EXPECT_STREQ(LocationOne->getIntervalInfo().c_str(),
                " Lines 100:100 [0x0000005000:0x0000005199]");
 
   set(LocationTwo, LineTwo, LineSix, 0x5200, 0x6100);
   EXPECT_STREQ(LocationTwo->getIntervalInfo().c_str(),
                " Lines 200:600 [0x0000005200:0x0000006100]");
 
-  set(LocationThree, LineThree, LineFive, 0x5400, 0x5800);
-  EXPECT_STREQ(LocationThree->getIntervalInfo().c_str(),
-               " Lines 300:500 [0x0000005400:0x0000005800]");
-
-  set(LocationFour, LineFour, LineFour, 0x5600, 0x5700);
-  EXPECT_STREQ(LocationFour->getIntervalInfo().c_str(),
-               " Lines 400:400 [0x0000005600:0x0000005700]");
-
   set(LocationFive, LineFive, LineFive, 0x5800, 0x5900);
   EXPECT_STREQ(LocationFive->getIntervalInfo().c_str(),
                " Lines 500:500 [0x0000005800:0x0000005900]");
 
   set(LocationSix, LineSix, LineSix, 0x6000, 0x6100);
   EXPECT_STREQ(LocationSix->getIntervalInfo().c_str(),
                " Lines 600:600 [0x0000006000:0x0000006100]");