[analyzer] Move unexecuted test block into it's own source file

[isuckatcs]

Summary

Inside lambdas.cpp a block of code wasn't executed,
because they required the standard to be at least
-std=c++14. This patch moves this block of code into
it's own source file.

[isuckatcs]

Added missing '\n' to the end of the new file.

[isuckatcs]

Moved clang_analyzer_eval() out of the lambda body, because no diagnostic was reported from the inside.

[xazax.hun]

In D135965#3858855, @isuckatcs wrote:

Moved clang_analyzer_eval() out of the lambda body, because no diagnostic was reported from the inside.

Interesting. Do you know why is that the case?

[isuckatcs]

In D135965#3858858, @xazax.hun wrote:

In D135965#3858855, @isuckatcs wrote:

Moved clang_analyzer_eval() out of the lambda body, because no diagnostic was reported from the inside.

Interesting. Do you know why is that the case?

I quickly looked at the source code of the said checker and I found this:

void ExprInspectionChecker::analyzerEval(const CallExpr *CE,
                                         CheckerContext &C) const {
  const LocationContext *LC = C.getPredecessor()->getLocationContext();

  // A specific instantiation of an inlined function may have more constrained
  // values than can generally be assumed. Skip the check.
  if (LC->getStackFrame()->getParent() != nullptr)
    return;

  reportBug(getArgumentValueString(CE, C), C);
}

I guess the parent stack frame of the lambda is the function in which it's declared, so the bug reportion is skipped.

[xazax.hun]

Oh, I see, this look deliberate. I wonder if we want to add an exception for lambdas though but that would be a different discussions unrelated to this PR.

[isuckatcs]

In D135965#3859148, @xazax.hun wrote:

Oh, I see, this look deliberate. I wonder if we want to add an exception for lambdas though but that would be a different discussions unrelated to this PR.

We could also consider reporting a warning or an error in this case to let the caller know that the function doesn't work in this context. Right now it's up to the caller to figure it out on their own, and if they don't see the report they might think there's something wrong with some other part of their code.

[xazax.hun]

In D135965#3859442, @isuckatcs wrote:

We could also consider reporting a warning or an error in this case to let the caller know that the function doesn't work in this context. Right now it's up to the caller to figure it out on their own, and if they don't see the report they might think there's something wrong with some other part of their code.

Good point! Such a warning would be really helpful.

clang/test/Analysis/lambdas-modern.cpp

+// RUN: %clang_analyze_cc1 -std=c++14 -analyzer-checker=core,debug.ExprInspection -analyzer-config inline-lambdas=true -verify %s
+// RUN: %clang_analyze_cc1 -std=c++17 -analyzer-checker=core,debug.ExprInspection -analyzer-config inline-lambdas=true -verify %s
+
+#include "Inputs/system-header-simulator-cxx.h"
+
+void clang_analyzer_warnIfReached();
+void clang_analyzer_eval(int);
+
+// Capture copy elided object.
+struct Elided{
+  int x = 0;
+  Elided(int) {}
+};
+
+void testCopyElidedObjectCaptured(int x) {
+  [e = Elided(x)] {
+    clang_analyzer_eval(e.x == 0); // expected-warning{{TRUE}}
+  }();
+}
+
+static auto MakeUniquePtr() { return std::make_unique<std::vector<int>>(); }
+
+void testCopyElidedUniquePtr() {
+  [uniquePtr = MakeUniquePtr()] {}();
+  clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
+}
 No newline at end of file

clang/test/Analysis/lambdas.cpp

void testVariableLengthArrayCaptured() {
 
   int i = [&]{
     return array[0];
   }();
 
   clang_analyzer_eval(i == 7); // expected-warning{{TRUE}}
 }
 
-#if __cplusplus >= 201402L
-// Capture copy elided object.
-
-struct Elided{
-  int x = 0;
-  Elided(int) {}
-};
-
-void testCopyElidedObjectCaptured(int x) {
-  [e = Elided(x)] {
-    clang_analyzer_eval(e.x == 0); // expected-warning{{TRUE}}
-  }();
-}
-
-static auto MakeUniquePtr() { return std::make_unique<std::vector<int>>(); }
-
-void testCopyElidedUniquePtr() {
-  [uniquePtr = MakeUniquePtr()] {}();
-  clang_analyzer_warnIfReached(); // expected-warning{{TRUE}}
-}
-
-#endif
-
 // Test inline defensive checks
 int getNum();
 
 void inlineDefensiveChecks() {
   int i = getNum();
   [=]() {
     if (i == 0)
       ;