Page MenuHomePhabricator

isuckatcs (Domján Dániel)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2022, 2:29 PM (28 w, 4 d)

Recent Activity

Yesterday

isuckatcs accepted D135290: [analyzer] Fix static code analysis concerns.
Wed, Oct 5, 11:40 AM · Restricted Project

Sat, Sep 17

isuckatcs committed rG6931d311eaf4: [analyzer] Cleanup some artifacts from non-POD array evaluation (authored by isuckatcs).
[analyzer] Cleanup some artifacts from non-POD array evaluation
Sat, Sep 17, 1:47 PM · Restricted Project, Restricted Project
isuckatcs closed D133643: [analyzer] Cleanup some artifacts from non-POD array evaluation.
Sat, Sep 17, 1:46 PM · Restricted Project, Restricted Project

Mon, Sep 12

isuckatcs added a comment to D133643: [analyzer] Cleanup some artifacts from non-POD array evaluation.

I wish we had asserts to catch this but that's not urgent I suppose.

Mon, Sep 12, 3:43 PM · Restricted Project, Restricted Project
isuckatcs planned changes to D133211: [analyzer][draft] Increase the accuracy of bug reports.

I would wait with commiting this until everything is addressed. The purpose of this patch was to quickly find a way to
get access to more information so that we might figure out whether the results from D132752 are true or false positives.

Mon, Sep 12, 3:40 PM · Restricted Project

Sat, Sep 10

isuckatcs updated the diff for D133643: [analyzer] Cleanup some artifacts from non-POD array evaluation.

Updated

Sat, Sep 10, 10:46 AM · Restricted Project, Restricted Project
isuckatcs requested review of D133643: [analyzer] Cleanup some artifacts from non-POD array evaluation.
Sat, Sep 10, 10:15 AM · Restricted Project, Restricted Project

Sep 5 2022

isuckatcs committed rGa11e51e91f73: [analyzer] Track trivial copy/move constructors and initializer lists in the… (authored by isuckatcs).
[analyzer] Track trivial copy/move constructors and initializer lists in the…
Sep 5 2022, 8:06 AM · Restricted Project, Restricted Project
isuckatcs closed D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.
Sep 5 2022, 8:06 AM · Restricted Project, Restricted Project

Sep 4 2022

isuckatcs committed rGa46154cb1cd0: [analyzer] Warn if the size of the array in `new[]` is undefined (authored by isuckatcs).
[analyzer] Warn if the size of the array in `new[]` is undefined
Sep 4 2022, 2:07 PM · Restricted Project, Restricted Project
isuckatcs closed D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.
Sep 4 2022, 2:07 PM · Restricted Project, Restricted Project

Sep 3 2022

isuckatcs updated the diff for D132752: [analyzer] Attempt to track region extent for binding.

Minor tweaks in overlapping region lookup

Sep 3 2022, 9:53 AM · Restricted Project
isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Updated the documentation

Sep 3 2022, 6:24 AM · Restricted Project, Restricted Project

Sep 2 2022

isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Addressed the nit

Sep 2 2022, 4:01 PM · Restricted Project, Restricted Project
isuckatcs committed rGb5147937b2a9: [analyzer] Add more information to the Exploded Graph (authored by isuckatcs).
[analyzer] Add more information to the Exploded Graph
Sep 2 2022, 3:21 PM · Restricted Project, Restricted Project
isuckatcs closed D131187: [analyzer] Add more information to the Exploded Graph.
Sep 2 2022, 3:21 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D133211: [analyzer][draft] Increase the accuracy of bug reports.

Updated the test files

Sep 2 2022, 8:43 AM · Restricted Project
isuckatcs requested review of D133211: [analyzer][draft] Increase the accuracy of bug reports.
Sep 2 2022, 8:25 AM · Restricted Project

Aug 31 2022

isuckatcs updated the diff for D131187: [analyzer] Add more information to the Exploded Graph.

Added a new test case where the program states are not empty in the dot files

Aug 31 2022, 6:51 AM · Restricted Project, Restricted Project

Aug 30 2022

isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Updated

Aug 30 2022, 4:39 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.
  • Addressed comments
  • Moved the checker to core from alpha.core
Aug 30 2022, 3:56 PM · Restricted Project, Restricted Project
isuckatcs committed rGcd40245f549b: [clang-tidy] Fix false positive on ArrayInitIndexExpr inside… (authored by isuckatcs).
[clang-tidy] Fix false positive on ArrayInitIndexExpr inside…
Aug 30 2022, 11:28 AM · Restricted Project, Restricted Project
isuckatcs closed D132654: [clang-tidy] Fix false positive on `ArrayInitIndexExpr` inside `ProBoundsConstantArrayIndexCheck`.
Aug 30 2022, 11:28 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D132654: [clang-tidy] Fix false positive on `ArrayInitIndexExpr` inside `ProBoundsConstantArrayIndexCheck`.

Removed the unnecessary extra RUN command.

Aug 30 2022, 10:24 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D132752: [analyzer] Attempt to track region extent for binding.

Removed the hack from RegionStoreManager::getLazyBinding().

Aug 30 2022, 2:53 AM · Restricted Project

Aug 29 2022

isuckatcs updated the diff for D131187: [analyzer] Add more information to the Exploded Graph.

Replaced one length string literals with char literals

Aug 29 2022, 3:31 PM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.
Aug 29 2022, 10:57 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.

Addressed comments

Aug 29 2022, 10:57 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131187: [analyzer] Add more information to the Exploded Graph.
Aug 29 2022, 10:05 AM · Restricted Project, Restricted Project
isuckatcs added a reviewer for D132654: [clang-tidy] Fix false positive on `ArrayInitIndexExpr` inside `ProBoundsConstantArrayIndexCheck`: gribozavr2.
Aug 29 2022, 6:40 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.

Addressed comments

Aug 29 2022, 6:14 AM · Restricted Project, Restricted Project

Aug 28 2022

isuckatcs updated the diff for D132752: [analyzer] Attempt to track region extent for binding.

Trying a different approach.

Aug 28 2022, 4:49 PM · Restricted Project

Aug 27 2022

isuckatcs added a comment to D127973: [analyzer] Eval construction of non POD type arrays..

I'm wondering if we should have a window for backward compatibility; There are a couple of places already where we check for the presence of some metadata and display it only if it exists.
Do you think it would be useful for this change as well?

Aug 27 2022, 7:29 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131187: [analyzer] Add more information to the Exploded Graph.

Empty traits are no longer dumped. This also solves the reverse compatibility issue caused by D127973.

Aug 27 2022, 7:27 AM · Restricted Project, Restricted Project

Aug 26 2022

isuckatcs requested review of D132752: [analyzer] Attempt to track region extent for binding.
Aug 26 2022, 11:55 AM · Restricted Project
isuckatcs added a comment to D127973: [analyzer] Eval construction of non POD type arrays..

I had the time for reducing it. Luckily it wasn't that bad.

Aug 26 2022, 12:37 AM · Restricted Project, Restricted Project

Aug 25 2022

isuckatcs updated the diff for D131187: [analyzer] Add more information to the Exploded Graph.
  • Rebased
  • Updated how the information is displayed.
  • Updated the screenshots of the nodes in the description to reflect the changes.
Aug 25 2022, 9:12 AM · Restricted Project, Restricted Project
isuckatcs added a comment to D127973: [analyzer] Eval construction of non POD type arrays..

Can you send me a snippet please, which reproduces this issue? For me the egraph rewriter works fine.

Aug 25 2022, 8:30 AM · Restricted Project, Restricted Project
isuckatcs requested review of D132654: [clang-tidy] Fix false positive on `ArrayInitIndexExpr` inside `ProBoundsConstantArrayIndexCheck`.
Aug 25 2022, 6:37 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Fixed the broken test file. Clang-format put a line break between {{ and }} and that caused the failure.

Aug 25 2022, 4:22 AM · Restricted Project, Restricted Project
isuckatcs committed rGe3e9082b013b: [analyzer] Fix for incorrect handling of 0 length non-POD array construction (authored by isuckatcs).
[analyzer] Fix for incorrect handling of 0 length non-POD array construction
Aug 25 2022, 3:42 AM · Restricted Project, Restricted Project
isuckatcs closed D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 25 2022, 3:42 AM · Restricted Project, Restricted Project
isuckatcs retitled D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction from [analyzer] Fix for incorrect handling of 0 size arrays to [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 25 2022, 3:41 AM · Restricted Project, Restricted Project

Aug 24 2022

isuckatcs added inline comments to D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 24 2022, 9:33 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 24 2022, 8:40 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.

@xazax.hun I added a test case for how I imagine flexible non-POD array members in C++

Aug 24 2022, 3:53 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Fixed docs build error

Aug 24 2022, 2:30 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.
Aug 24 2022, 1:59 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Added a documentation into checkers.rst.

Aug 24 2022, 1:59 AM · Restricted Project, Restricted Project

Aug 23 2022

isuckatcs committed rGaac73a31add5: [analyzer] Process non-POD array element destructors (authored by isuckatcs).
[analyzer] Process non-POD array element destructors
Aug 23 2022, 4:29 PM · Restricted Project, Restricted Project
isuckatcs closed D130737: [analyzer] Process non-POD array element destructors.
Aug 23 2022, 4:28 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.

Fixed an error prone line

Aug 23 2022, 3:55 AM · Restricted Project, Restricted Project

Aug 22 2022

isuckatcs added inline comments to D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 22 2022, 11:21 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 22 2022, 11:04 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.

Rebase and addressed some comments.

Aug 22 2022, 11:03 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.
Aug 22 2022, 11:01 AM · Restricted Project, Restricted Project
isuckatcs committed rGc81bf940c77e: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr (authored by isuckatcs).
[analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr
Aug 22 2022, 4:54 AM · Restricted Project, Restricted Project
isuckatcs closed D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
Aug 22 2022, 4:54 AM · Restricted Project, Restricted Project
isuckatcs committed rG3c482632e64c: [analyzer] Remove pattern matching of lambda capture initializers (authored by isuckatcs).
[analyzer] Remove pattern matching of lambda capture initializers
Aug 22 2022, 4:01 AM · Restricted Project, Restricted Project
isuckatcs closed D131944: [analyzer] Remove pattern matching of lambda capture initializers.
Aug 22 2022, 4:01 AM · Restricted Project, Restricted Project

Aug 21 2022

isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.
  • Fixed another error prone function
  • Added a new test case
Aug 21 2022, 8:28 AM · Restricted Project, Restricted Project

Aug 20 2022

isuckatcs added inline comments to D130737: [analyzer] Process non-POD array element destructors.
Aug 20 2022, 1:12 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.

Handling the case when DynamicExtent returns a non-integer array size.

Aug 20 2022, 1:05 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.

Handling the case when we cache out a node.

Aug 20 2022, 9:33 AM · Restricted Project, Restricted Project

Aug 19 2022

isuckatcs committed rGa47ec1b79797: [analyzer][NFC] Be more descriptive when we replay without inlining (authored by isuckatcs).
[analyzer][NFC] Be more descriptive when we replay without inlining
Aug 19 2022, 9:06 AM · Restricted Project, Restricted Project
isuckatcs closed D132246: [analyzer][NFC] Be more descriptive when we replay without inlining.
Aug 19 2022, 9:06 AM · Restricted Project, Restricted Project
isuckatcs requested review of D132246: [analyzer][NFC] Be more descriptive when we replay without inlining.
Aug 19 2022, 8:56 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.

Moved the declaration of extractElementInitializerFromNestedAILE to CFG.h.

Aug 19 2022, 8:27 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.

Added a testcase for the crashing snippet.

Aug 19 2022, 8:11 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.

Added a testcase for the crashing snippet. (Wrong revision)

Aug 19 2022, 8:10 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.
  • EpsilonPoint -> PreImplicitCall
  • Added test for multidimensional zero length array
Aug 19 2022, 8:06 AM · Restricted Project, Restricted Project
isuckatcs added a comment to D130737: [analyzer] Process non-POD array element destructors.

Ok one more crash!

This one causes infinite recursion in CoreEngine::dispatchWorkItem() where it handles EpsilonPoint which loops back to itself??? So it can manifest either as a segfault or as a hang depending on whether you're compiling with tail recursion.

struct a {
  a *b;
};
struct c {
  a d;
  c(int);
  ~c() {
    for (a e = d;; e = *e.b)
      ;
  }
};
void f() { c g(0); }
Aug 19 2022, 6:20 AM · Restricted Project, Restricted Project

Aug 18 2022

isuckatcs updated the diff for D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.

@xazax.hun is this how you meant it?

Aug 18 2022, 4:25 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.

Addressed comment

Aug 18 2022, 3:24 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.

Updated initializer list handling

Aug 18 2022, 2:21 AM · Restricted Project, Restricted Project

Aug 17 2022

isuckatcs updated the diff for D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.

Updated

Aug 17 2022, 1:10 PM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.
Aug 17 2022, 12:26 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.

Rewrote from scratch

Aug 17 2022, 12:25 PM · Restricted Project, Restricted Project

Aug 16 2022

isuckatcs added inline comments to D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
Aug 16 2022, 2:47 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
Aug 16 2022, 2:43 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
  • Rebased
  • Moved extractElementInitializerFromNestedAILE() to ExprEngine
  • Addressed comments
Aug 16 2022, 2:42 AM · Restricted Project, Restricted Project
isuckatcs requested review of D131944: [analyzer] Remove pattern matching of lambda capture initializers.
Aug 16 2022, 12:51 AM · Restricted Project, Restricted Project

Aug 15 2022

isuckatcs updated the diff for D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter.
  • Progressed with initializer lists.
  • Added more tests.
Aug 15 2022, 3:24 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
  • Moved getArrayInitLoopExprSize() to ASTContext.
  • Addressed comments.
Aug 15 2022, 3:42 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.
  • Addressed comment
  • Generating a "zero length array skip" node in all cases
Aug 15 2022, 2:31 AM · Restricted Project, Restricted Project

Aug 14 2022

isuckatcs added inline comments to D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
Aug 14 2022, 1:39 PM · Restricted Project, Restricted Project

Aug 13 2022

isuckatcs updated the diff for D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.

Rebased and added more test cases

Aug 13 2022, 11:56 AM · Restricted Project, Restricted Project
isuckatcs requested review of D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
Aug 13 2022, 8:43 AM · Restricted Project, Restricted Project

Aug 12 2022

isuckatcs updated the diff for D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.

Rebased

Aug 12 2022, 4:13 PM · Restricted Project, Restricted Project
isuckatcs committed rGb4e3e3a3eb77: [analyzer] Fix a crash on copy elided initialized lambda captures (authored by isuckatcs).
[analyzer] Fix a crash on copy elided initialized lambda captures
Aug 12 2022, 3:22 PM · Restricted Project, Restricted Project
isuckatcs closed D131784: [analyzer] Fix a crash on copy elided initialized lambda captures.
Aug 12 2022, 3:22 PM · Restricted Project, Restricted Project
isuckatcs requested review of D131784: [analyzer] Fix a crash on copy elided initialized lambda captures.
Aug 12 2022, 8:27 AM · Restricted Project, Restricted Project

Aug 11 2022

isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.

Handling multidimensional member dtors too.

Aug 11 2022, 5:28 PM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.

Handling multidimensional delete dtors properly. It turned out the constructor wasn't modelling the type of the region correctly.

Aug 11 2022, 4:40 PM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
Aug 11 2022, 10:00 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction.
  • Addressed comments
  • Added more testcases
Aug 11 2022, 10:00 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D130737: [analyzer] Process non-POD array element destructors.
  • Handling 0 length arrays
  • Partially handling multidimensional arrays (doesn't work properly for delete and member dtors)
Aug 11 2022, 9:56 AM · Restricted Project, Restricted Project
isuckatcs added inline comments to D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.
Aug 11 2022, 1:25 AM · Restricted Project, Restricted Project
isuckatcs updated the diff for D131299: [analyzer] Warn if the size of the array in `new[]` is undefined.

Addressed comments

Aug 11 2022, 1:25 AM · Restricted Project, Restricted Project

Aug 10 2022

isuckatcs added a comment to D130974: [analyzer] Fix for the crash in #56873.

If so, shouldn't be some dependencies across these revisions?

Aug 10 2022, 9:00 AM · Restricted Project, Restricted Project