This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add GFX11 tests for fcmp and ballot. NFC
ClosedPublic

Authored by Joe_Nash on Oct 12 2022, 7:55 AM.

Diff Detail

Unit TestsFailed

Event Timeline

Joe_Nash created this revision.Oct 12 2022, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 7:55 AM
Joe_Nash requested review of this revision.Oct 12 2022, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 7:55 AM
foad accepted this revision.Oct 12 2022, 8:07 AM

Seems obviously fine.

llvm/test/CodeGen/AMDGPU/v_cmp_gfx11.ll
16

It's a bit nicer to use named values instead of numbered.

39

Same.

This revision is now accepted and ready to land.Oct 12 2022, 8:07 AM
arsenm added inline comments.Oct 12 2022, 8:26 AM
llvm/test/CodeGen/AMDGPU/v_cmp_gfx11.ll
3

global-isel=1 and =0 lines?

Joe_Nash marked 2 inline comments as done.Oct 12 2022, 12:41 PM
Joe_Nash added inline comments.
llvm/test/CodeGen/AMDGPU/v_cmp_gfx11.ll
3

It appears that global-isel selection for 16 bit types in llvm.amdgcn.icmp and even 32 bit types for llvm.amdgcn.fcmp is incomplete. Therefore I will file a ticket but not fix it in this patch. https://github.com/llvm/llvm-project/issues/58326

This revision was landed with ongoing or failed builds.Oct 12 2022, 12:57 PM
This revision was automatically updated to reflect the committed changes.